Missing alignment default value in image constructor

[mloskot]

Actual behavior

Unlike all the other constructors, this one does not receive default value alignment = 0

gil/include/boost/gil/image.hpp

Lines 78 to 84 in 291b277

	image(const point_t& dimensions,
	const Pixel& p_in,
	std::size_t alignment,
	const Alloc alloc_in = Alloc()) : _memory(nullptr), _align_in_bytes(alignment), _alloc(alloc_in)
	, _allocated_bytes( 0 ) {
	allocate_and_fill(dimensions, p_in);
	}

#include <boost/gil.hpp>
namespace gil = boost::gil;
int main()
{
    gil::point_t dims{32, 32};
    gil::bgr8_pixel_t p{32, 64, 128};
    gil::bgr8_image_t i(dims, p);
      // image(const point_t& dimensions, const Pixel& p_in, std::size_t alignment, const Alloc alloc_in = Alloc())
      // constructor is not picked up, compilation fails
}

Expected behavior

gil::bgr8_image_t i(dims, p); should pick the expected constructor.

References

• This bug causes failures of the newly proposed image tests test: Add more basic cases for image class #423

Environment

• Compiler version: GCC 9.2, clang 9.0, VS 2017, VS 2019

[parthsarthi1]

@mloskot can I try to look into the issue to learn more about GIL. thanks.

[mloskot]

@parthsarthi1 You're welcome to take care of it and submit PR. No tests need to be added for it because #423 will add some (I'll update that PR as soon as your PR is merged).

You should try to compile the minimal example from the description to see if your fix works though.

[ArbitCode]

@mloskot I think this issue is resolved as while I'm trying to find the issue. I haven't seen any issues.

[mloskot]

@ArbitCode What compiler did you use? What C++ standard version?

[ArbitCode]

sorry, Actually that time it does not show the error when I was finding bugs, Now it shows error.
FYI gcc 9.2. This is the right compiler, isn't it?

[mloskot]

@ArbitCode So, you confirm the issue. Good.

I added list of compilers that I tried to the description.