Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add more basic cases for image class #423

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Jan 19, 2020

Description

This hopefully will begin extensive test suite for the image class to
maintain decent coverage for this major class of GIL.

References

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass

@mloskot mloskot added core boost/gil test New tests development or missing tests issues, no new functionality labels Jan 19, 2020
@mloskot mloskot self-assigned this Jan 19, 2020
@mloskot mloskot added this to the Boost 1.73 milestone Jan 19, 2020
@mloskot mloskot added the status/work-in-progress Do NOT merge yet until this label has been removed! label Jan 19, 2020
mloskot added a commit to mloskot/gil that referenced this pull request Feb 1, 2020
mloskot added a commit that referenced this pull request Feb 1, 2020
@mloskot mloskot changed the title Add basic test cases for image class Add more basic test cases cases for image class Feb 1, 2020
@mloskot mloskot modified the milestones: Boost 1.73, Boost 1.74+ Apr 21, 2020
@mloskot mloskot modified the milestones: Boost 1.74, Boost 1.75+ Jul 11, 2020
@mloskot mloskot modified the milestones: Boost 1.75, Boost 1.76+ Nov 10, 2020
Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code point of view looks good but we moved away from boost tests :)

This hopefully will begin extensive test suite for the image class to
maintain decent coverage for this major class of GIL.
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #423 (9a4d72c) into develop (4dbf35a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #423      +/-   ##
===========================================
+ Coverage    80.93%   80.95%   +0.01%     
===========================================
  Files          116      116              
  Lines         5130     5130              
===========================================
+ Hits          4152     4153       +1     
+ Misses         978      977       -1     

@mloskot mloskot removed the status/work-in-progress Do NOT merge yet until this label has been removed! label Jun 29, 2022
@mloskot mloskot merged commit 2409be4 into boostorg:develop Jun 29, 2022
@mloskot mloskot deleted the ml/add-image-class-test branch June 29, 2022 21:00
@mloskot mloskot changed the title Add more basic test cases cases for image class test: Add more basic cases for image class Jun 29, 2022
mloskot added a commit that referenced this pull request Jun 29, 2022
* develop:
  test: Add more basic cases for image class (#423)
  test: Add virtual_2d_locator fixture; is_2d_traversable test case
  test: Check more properties of indexed_image_view from extension/toolbox
  test: Add basic is_1d_traversable cases for image_view
  chore: Update CMakeSettings.json sample [ci skip]
  chore: Update CMake to use latest cmake-conan/0.18.1 [ci skip]
  Add pmr image typedefs (#529)
  test: Add test cases for image with empty dimensions (#702)
  test: Case test_constructor_from_view was not called
  fix: Memory leak in image class for empty dimensions (#649)
  docs: Bump C++11 to C++14 as current required (#700)
  ci: Remove C++11 build jobs after C++14 switch (#698)
  build: Fix CMake source file extensions must be explicit
  refactor: Switch to trailing return types (#599)
  build: Bump Boost required by CMake from 1.72 to 1.80
  build: Update CMAKE_CXX_STANDARD from 11 to 14
@mloskot mloskot mentioned this pull request Jul 5, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core boost/gil test New tests development or missing tests issues, no new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants