Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for RGB to HSL #691

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Jun 25, 2022

Description

Contributor of PR #505 posted GTest-based tests in.
This commit ports those tests to Boost.LightweightTest.

References

Closes #690

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

Contributor of PR boostorg#505 posted GTest-based tests in.
This commit ports those tests to Boost.LightweightTest.

Closes boostorg#690
@mloskot mloskot added the test New tests development or missing tests issues, no new functionality label Jun 25, 2022
@mloskot mloskot added this to the Boost 1.80 milestone Jun 25, 2022
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #691 (98d231c) into develop (d50d856) will increase coverage by 0.57%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #691      +/-   ##
===========================================
+ Coverage    78.78%   79.35%   +0.57%     
===========================================
  Files          117      117              
  Lines         5029     5029              
===========================================
+ Hits          3962     3991      +29     
+ Misses        1067     1038      -29     

@mloskot mloskot self-assigned this Jun 25, 2022
@mloskot mloskot merged commit 0f43590 into boostorg:develop Jun 25, 2022
@mloskot mloskot deleted the ml/add-test-for-pr505 branch June 25, 2022 16:51
mloskot added a commit that referenced this pull request Jun 27, 2022
* develop:
  docs!: Announce plan to require C++17 after Boost 1.80 (#694)
  feat: Added apply_rasterizer() free function (#695)
  refactor: Ellipse rasterizer according to the comment at (#692)
  refactor: Deprecate apply_operation in favor of variant2::visit for any_image (#656)
  refactor: Replace deprecated libtiff v4.3 typedefs with C99 fixed-size integers (#685)
  fix: Automatic detection of <filesystem> header (#684)
  test: Add tiled TIFF test case to simple_all_formats
  test: Add tests for RGB to HSL (#691)
  refactor: Move RGB to HSL tests to color_convert_rgb.cpp
  refactor: Make with_tolerance reusable across other tests
  chore: Correct include guard
  fix: Add missing #include <array>
  fix: Wrong RGB -> HSL convertion (#505)
@mloskot mloskot mentioned this pull request Jul 5, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test New tests development or missing tests issues, no new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for PR #505 with RGB to HSL fix
1 participant