refactor: ellipse rasterizer #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #692 +/- ##
========================================
Coverage 80.32% 80.32%
========================================
Files 117 117
Lines 5032 5032
========================================
Hits 4042 4042
Misses 990 990 |
mloskot
added
ext/rasterization
mloskot
approved these changes
Jun 26, 2022
There was a problem hiding this comment.
Thank you very much!
Since @meshtag reacted to your questions in #585 (comment) and he did not express any objections, I'm happy to approve it and merge it for Boost 1.80
3 tasks
meshtag
reviewed
Jun 26, 2022
mloskot
added a commit
that referenced
this pull request
Jun 27, 2022
* develop: docs!: Announce plan to require C++17 after Boost 1.80 (#694) feat: Added apply_rasterizer() free function (#695) refactor: Ellipse rasterizer according to the comment at (#692) refactor: Deprecate apply_operation in favor of variant2::visit for any_image (#656) refactor: Replace deprecated libtiff v4.3 typedefs with C99 fixed-size integers (#685) fix: Automatic detection of <filesystem> header (#684) test: Add tiled TIFF test case to simple_all_formats test: Add tests for RGB to HSL (#691) refactor: Move RGB to HSL tests to color_convert_rgb.cpp refactor: Make with_tolerance reusable across other tests chore: Correct include guard fix: Add missing #include <array> fix: Wrong RGB -> HSL convertion (#505)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements some of the mentioned issues in my other comment regarding the ellipse rasterizer, namely:
midpoint_elliptical_rasterizertomidpoint_ellipse_rasterizerThere are still some open questions, e.g. why circle/line and ellipse rasterizer have different signedness for point types and why they implement the call operator differently. However, I am not sure if we are able to find any consensus on these topics before the deadline for Boost 1.80.
Tasklist