Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration plans for nREPL 0.4 #695

Closed
bbatsov opened this issue May 20, 2018 · 3 comments · Fixed by #703
Closed

Migration plans for nREPL 0.4 #695

bbatsov opened this issue May 20, 2018 · 3 comments · Fixed by #703

Comments

@bbatsov
Copy link
Contributor

bbatsov commented May 20, 2018

That's basically a follow up of nrepl/nrepl#1 and was also discussed in nrepl/nrepl#4.

TL;DR; - In verions 0.4 of the "new" nREPL the namespaces will be changed from clojure.tools.nrepl.* to nrepl.*.

As this is a different artifact technically speaking(nrepl/nrepl instead of clojure.tools/nrepl) I think the best migration path for Boot would be to just start depending on both projects and have two tasks for the two nREPLs until we can drop the old version (e.g. boot repl and boot nrepl). The second task can just start a headless server until reply adds support for nrepl/nrepl.

How does this sound?

@arichiardi
Copy link
Contributor

It sounds like a good approach for me.

bbatsov added a commit to bbatsov/boot that referenced this issue Jun 26, 2018
nREPL was recently moved out of clojure-contrib and it's developed
continued under a dedicated org. The new project is (and will remain
to be) completely backwards compatible on the nREPL API level, but
the namespace had to be changed.

This fixes boot-clj#695.
bbatsov added a commit to bbatsov/boot that referenced this issue Jun 29, 2018
nREPL was recently moved out of clojure-contrib and it's developed
continued under a dedicated org. The new project is (and will remain
to be) completely backwards compatible on the nREPL API level, but
the namespace had to be changed.

This fixes boot-clj#695.
@alandipert
Copy link
Contributor

I like the idea of adding a new nrepl task 👍

@bbatsov
Copy link
Contributor Author

bbatsov commented Aug 5, 2018

@alandipert I'm not sure if that makes sense any more, as pretty much all of the essential middleware got updated to support nREPL 0.4 while this and #703 stayed open. Seems to me at this point it would just be simpler to directly switch to 0.4 (and that's also what lein did already - it switch to nREPL 0.4 in master).

If you insist on a boot nrepl we can make this happen, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants