Update nREPL to 0.4.4 #703
Conversation
|
Thanks @bbatsov, if this is a backward compatible change I can't see any reason not to do it. |
|
Oh, this could use a CHANGELOG.md entry though. Thanks in advance for adding one that summarizes the change. |
|
Just for future reference, this is not really backward compatible, see: However the tooling goal would be to move towards it we could bump |
The protocol is completely the same, but the project has a new namespace, which means that middleware will need small tweaks to work with it. That being said - I'm the direct author/maintainer of almost all popular nREPL middleware and I do plan to switch them to target the new nREPL anyways. :-)
Of course. I'll add this in a bit. |
|
Changelog entry added. |
bbatsov
force-pushed
the
new-nrepl
branch
2 times, most recently
from
9a992b0
to
679f8d3
Compare
|
PR updated for nREPL 0.4.3. |
CHANGES.md
Outdated
| @@ -8,6 +8,16 @@ | |||
|
|
|||
| [702]: https://github.com/boot-clj/boot/pull/702 | |||
|
|
|||
| #### Breaking | |||
|
|
|||
| Updated nREPL to 0.4.3. The new nREPL has a new artefact coordinates | |||
There was a problem hiding this comment.
Not in my part of the world. 😆
There was a problem hiding this comment.
Sure, just noted it to keep it in line with maven spelling:
Also: https://github.com/boot-clj/boot/search?q=artifact&unscoped_q=artifact
vs.
https://github.com/boot-clj/boot/search?q=artefact&unscoped_q=artefact
There was a problem hiding this comment.
Yeah, yeah. I know everyone in programming uses American English spellings, but it's hard for me to remember this all the time. Especially when my spell checker highlights artifact as incorrect. :-)
|
The build failure is unrelated, btw. @alandipert Can you tell me if you want us to move forward with this or not? I've invested a tremendous amount of time already coordinating the nREPL upgrade across all related projects and that's the final missing piece. I'd be extremely happy if we can just wrap this up and I can focus on actually improving the server and its middleware. :-) |
nREPL was recently moved out of clojure-contrib and it's developed continued under a dedicated org. The new project is (and will remain to be) completely backwards compatible on the nREPL API level, but the namespace had to be changed.
|
Thanks! |
As no one really commented on #695 I've decided to try an alternative approach to get some conversation going. Here's my preferred (quick) solution to the migration to the new nREPL. I know this is probably less than ideal, but it's a one time deal, and I'd really appreciate your support as I rather be dealing with nREPL improvements than with migration paths.
nREPL was recently moved out of clojure-contrib and its development
continued under a dedicated org (https://github.com/nrepl). The new project is (and will remain
to be) completely backwards compatible on the nREPL API level, but
the namespace had to be changed.
This fixes #695.