Update nREPL to 0.4.3 #2444
Merged
Update nREPL to 0.4.3 #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nREPL was recently moved out of clojure-contrib and its development continued under a dedicated org (https://github.com/nrepl). The new project is (and will remain to be) completely backwards compatible on the nREPL API level, but the namespace had to be changed. This fixes technomancy#2434.
|
See also boot-clj/boot#703 |
This was referenced Jul 7, 2018
|
I've also created one simple plugin, so people can easily use nREPL 0.4, while waiting for this to be merged. (https://github.com/nrepl/lein-nrepl) |
razum2um
reviewed
Jul 25, 2018
| @@ -54,7 +54,7 @@ | |||
| org.apache.maven/maven-resolver-provider "3.5.0" | |||
| org.clojure/data.xml "0.0.8" | |||
| org.clojure/tools.macro "0.1.5" | |||
| org.clojure/tools.nrepl "0.2.12" | |||
| nrepl "0.4.1g" | |||
|
I've updated the PR to nREPL 0.4.3. |
|
Looks good; thanks. |
|
🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As no one really commented on #2434 I've decided to try an alternative approach. Here's my preferred (quick) solution to the migration to the new nREPL. I know this is probably less than ideal, but it's a one time deal, and I'd really appreciate your support as I rather be dealing with nREPL improvements than with migration paths.
nREPL was recently moved out of clojure-contrib and its development
continued under a dedicated org (https://github.com/nrepl). The new project is (and will remain
to be) completely backwards compatible on the nREPL API level, but
the namespace had to be changed.
This fixes #2434.