[#513] remove noRdAdmin profile #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilkins-csi
commented
Dec 20, 2024
| @@ -18,7 +18,15 @@ _Note: instructions for adapting to these changes are outlined in the upgrade in | |||
|
|
|||
|
|
|||
| # Known Issues | |||
| _There are no known issues with the 1.11 release._ | |||
|
|
|||
| ## Docker Module Build Failures | |||
There was a problem hiding this comment.
I: Putting this in known issues to keep pressure on us to smooth this out.
The TestContainers now respects the docker context so an explicit profile is no longer needed. Also fixes the healthcheck URL for drift-detection tests so the ITs don't wait the full timeout every time.
ewilkins-csi
force-pushed
the
513-remove-inflight-changes
branch
from
5eb5883 to
410135f
Compare
ewilkins-csi
commented
Dec 20, 2024
| @@ -38,7 +38,7 @@ def before_all(context): | |||
| ) | |||
|
|
|||
| # call to health check to verify Drift Detection Services are started | |||
| health_check_url = "http://localhost:8084/q/health/live" | |||
| health_check_url = "http://localhost:8084/invoke-drift/health-check" | |||
There was a problem hiding this comment.
I: The previous healthcheck URL is not a valid endpoint in our deployment. This was causing the ITs to wait the full timeout and eventually print an error before continuing on to successfully execute the actual tests.
ewilkins-csi
changed the title
cwoods-cpointe
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestContainers now respects the docker context so an explicit profile is no longer needed. Also fixes the healthcheck URL for drift-detection tests so the ITs don't wait the full timeout every time.
Ideally, we would use docker socket detection logic with
file.existsandfile.missingprofile activations to update thedockerHostconfiguration ordocker.hostproperty of the docker-maven-plugin as indicated by the build error message when DOCKER_HOST is unset. However, because that plugin creates it's ownconfig.jsonwith only auth settings and always passes in--configduring a buildx build, the builder will always look for the docker socket at /var/run/docker.sock. We will need to update the docker-maven-plugin source code to respectdockerHostduring this config creation.