Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

boozallen / aissemble Public

Notifications You must be signed in to change notification settings
Fork 9
Star 36

Code
Issues 27
Pull requests 2
Discussions
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature:Remove in-flight changes that prevent immediate release #513

Closed

12 tasks done

ewilkins-csi opened this issue Dec 19, 2024 · 3 comments

Closed

12 tasks done

Feature:Remove in-flight changes that prevent immediate release #513

ewilkins-csi opened this issue Dec 19, 2024 · 3 comments

Assignees

Labels

New feature or request

Milestone

Comments

Copy link

Contributor

ewilkins-csi commented Dec 19, 2024 •

edited

Loading

Description

In our recent work on path to production alignment and baking in the universal config store, we've drifted away from our goal of always being ready to cut a release. We want to get back to a good state and move any changes that requires further work to fully polish to feature branches so we can respond more quickly to demand.

DOD

Path to production alignment changes that prevent deployment via Tilt or introduce files to support local ArgoCD deployment are moved to a feature branch
- New infrastructure module is removed
- New deploy shell script it removed
- Other changes are analyzed and removed as appropriate
- Remove any migrations specific to the removed changes
Universal config work that will force projects to setup the config store are moved to a feature branch
- Default usage of injection hooks in spark-infrastructure charts is removed
- Other changes are analyzed and removed as appropriate
- Remove any migrations specific to the removed changes
Ensure release notes do not include any instructions/information about changes that have been moved to feature branches
Ensure Antora docs do not contain information for changes moved to feature branches
For tickets that introduced the changes moved to feature branches, ensure a paper trail is left leading back to this ticket

Test Strategy/Script

Create a new project

mvn archetype:generate '-DarchetypeGroupId=com.boozallen.aissemble' \
                       '-DarchetypeArtifactId=foundation-archetype' \
                       '-DarchetypeVersion=1.11.0-SNAPSHOT' \
                       '-DgroupId=org.test' \
                       '-Dpackage=org.test' \
                       '-DprojectGitUrl=test.org/test.git' \
                       '-DprojectName=Test Project' \
                       '-DartifactId=final-513'

Verify there is no final-513-infrastructure module or a deploy.sh script
Add SparkPipeline.json to final-513-pipeline-models/src/main/resources/pipelines
Build the project and resolve manual actions until none are printed
Run the build again with the cache disabled and apply final manual actions: mvn clean install -Dmaven.build.cache.skipCache
Deploy the project with tilt up
Verify all resource start successfully
Run the spark-pipeline resource and verify it completes successfully

The text was updated successfully, but these errors were encountered:

All reactions

ewilkins-csi added the enhancement New feature or request label

ewilkins-csi added this to the 1.11.0 milestone

ewilkins-csi self-assigned this

ewilkins-csi changed the title ~~Feature: Get development branch back to releasable state~~ Feature:Remove in-flight changes that prevent immediate release

Copy link

Contributor Author

ewilkins-csi commented Dec 19, 2024

DoD with @nartieri

All reactions

Sorry, something went wrong.

ewilkins-csi added a commit that referenced this issue


          [#513] remove code preventing release of 1.11

f820423

Rolls back changes related to local ArgoCD deployment and the
integration of Universal Config with the spark-infrastructure chart.
Includes release notes updates and Baton migrations.

ewilkins-csi added a commit that referenced this issue


          [#513] isolate UC changes for release

a63e166

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #483 (9b4c2b6) merged in #487
 - #483 (33b597a) merged in #489
 - #488 (5bf5151) merged in #493

ewilkins-csi added a commit that referenced this issue


          [#513] isolate UC changes for release

65ecf77

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

ewilkins-csi added a commit that referenced this issue


          [#513] restore PTPA changes to feature branch

c029568

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #483 (9b4c2b6) merged in #487
 - #483 (33b597a) merged in #489
 - #488 (5bf5151) merged in #493

ewilkins-csi added a commit that referenced this issue


          [#513] restore UC changes to feature branch

e5f5f8a

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

This was referenced Dec 19, 2024

Feature: Align deployment mechanism from Development to Production #483

Closed

TASK: Investigate and document method for testing locally-modified baseline helm charts in ArgoCD #488

Closed

Feature: integrate Universal Config store in the hive metastore service #484

Closed

Clean up ConfigMap Logic in the Hive-metastore-service to improve space complexity #501

Closed

Copy link

Contributor

csun-cpointe commented Dec 19, 2024

OTS completed!

All reactions

Sorry, something went wrong.

ewilkins-csi added a commit that referenced this issue


          [#513] remove code preventing release of 1.11

b88232d

Rolls back changes related to local ArgoCD deployment and the
integration of Universal Config with the spark-infrastructure chart.
Includes release notes updates and Baton migrations.

ewilkins-csi added a commit that referenced this issue


          [#513] remove code preventing release of 1.11

294ff31

Rolls back changes related to local ArgoCD deployment and the
integration of Universal Config with the spark-infrastructure chart.
Includes release notes updates and Baton migrations.

ewilkins-csi added a commit that referenced this issue


          [#513] restore UC changes to feature branch

12f1aef

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

ewilkins-csi added a commit that referenced this issue


          [#513] restore UC changes to feature branch

88846cc

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

ewilkins-csi added a commit that referenced this issue


          [#513] restore PTPA changes to feature branch

1dfdaa9

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #483 (9b4c2b6) merged in #487
 - #483 (33b597a) merged in #489
 - #488 (5bf5151) merged in #493

ewilkins-csi added a commit that referenced this issue


          Merge pull request #514 from boozallen/513-remove-inflight-changes

5753a64

[#513] remove code preventing release of 1.11

ewilkins-csi added a commit that referenced this issue


          [#513] detect docker socket location automatically

cf1e345

ewilkins-csi added a commit that referenced this issue


          [#513] detect docker socket location automatically

d250282

ewilkins-csi added a commit that referenced this issue


          [#513] detect docker socket location automatically

5eb5883

This change makes the explicit usage of `noRdAdmin` no longer required.
Ideally, we would use this same logic to configure the `dockerHost`
configuration or `docker.host` property of the docker-maven-plugin as
indicated by the build error message when DOCKER_HOST is unset. However
because that plugin creates it's own `config.json` with only auth
settings and always passes in `--config` during a buildx build, the
builder will always look for the docker socket at /var/run/docker.sock.
We will need to update the docker-maven-plugin source code to respect
`dockerHost` during this config creation.

ewilkins-csi added a commit that referenced this issue


          [#513] remove noRdAdmin profile

410135f

The TestContainers now respects the docker context so an explicit
profile is no longer needed.

Also fixes the healthcheck URL for drift-detection tests so the ITs
don't wait the full timeout every time.

ewilkins-csi added a commit that referenced this issue


          Merge pull request #515 from boozallen/513-remove-inflight-changes

6bc370b

[#513] remove noRdAdmin profile

ewilkins-csi added a commit that referenced this issue


          [#513] restore UC changes to feature branch

498bb94

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

ewilkins-csi added a commit that referenced this issue


          [#513] restore PTPA changes to feature branch

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #483 (9b4c2b6) merged in #487
 - #483 (33b597a) merged in #489
 - #488 (5bf5151) merged in #493

Copy link

Collaborator

nartieri commented Dec 20, 2024

Verification:

No final-513 module and no deploy.sh script:
Successful project build:
Successful pipeline run.

All reactions

Sorry, something went wrong.

nartieri closed this as completed

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

578dead

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

41eb252

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

d1ac0ca

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

6185e4c

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

eedeca3

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

57604b4

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

3dc352c

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

ewilkins-csi added a commit that referenced this issue


          [#513] restore PTPA changes to feature branch

7d75a0f

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #483 (9b4c2b6) merged in #487
 - #483 (33b597a) merged in #489
 - #488 (5bf5151) merged in #493

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

fc31bdb

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

1a596f7

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

jaebchoi pushed a commit that referenced this issue


          [#513] restore UC changes to feature branch

To allow for the dev branch to be released, the changes in this commit
were reverted and moved to this feature branch.  The original work was
done in the following tickets:
 - #484 (ddbc3ad) merged in #494
 - #501 (c817c5f) merged in #504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

Labels

New feature or request

Projects

None yet

Milestone

1.11.0

Development

No branches or pull requests

3 participants

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.