[#513] remove code preventing release of 1.11 #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csun-cpointe
approved these changes
Dec 19, 2024
aaron-gary
reviewed
Dec 20, 2024
| * When completing and locally testing a migration of a module to Extensions Helm, the above steps can be taken. | ||
| * As a precursor to the above steps, it would be helpful to create a simple aiSSEMBLE project to use as a test-bed. | ||
| * It is important to note that because the module's helm charts will not be published to the Helm Repository remote | ||
| until a build via GitHub Actions is completed, the `repository` field in the module's `Chart.yaml` file must be updated |
There was a problem hiding this comment.
Q: Is this a scenario where after the release and subsequent build in GHA then the workaround is no longer needed? Just trying to understand the scenario.
There was a problem hiding this comment.
Yeah this is specifically to test chart changes pre-merge to dev. After that the changes would be available in ghcr.io as the lastest snapshot.
Because ArgoCD is strictly GitOps it required a special approach. Since we're not yet switching over to Argo for local, the old instructions apply.
aaron-gary
approved these changes
Dec 20, 2024
chang-annie
reviewed
Dec 20, 2024
jaebchoi
reviewed
Dec 20, 2024
jaebchoi
approved these changes
Dec 20, 2024
Rolls back changes related to local ArgoCD deployment and the integration of Universal Config with the spark-infrastructure chart. Includes release notes updates and Baton migrations.
ewilkins-csi
force-pushed
the
513-remove-inflight-changes
branch
from
f820423 to
b88232d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back changes related to local ArgoCD deployment and the integration of Universal Config with the spark-infrastructure chart. Includes release notes updates and Baton migrations.
Tickets with rolled back changes: