#484 Feature: integrate Universal Config store in the hive metastore service

[jaebchoi]

#484

[ewilkins-csi]

A: Seems like we might want to be more precise and attach labels only to the resources that need it instead of using this commonLables field.

[jaebchoi]

Yup! I wish I would inject label for specific to kind, but looking at mysql's logic all metadata's label logic is embedded to use only commonLabels. see here for example code snippet for mysql chart

{{- if eq .Values.architecture "replication" }}
apiVersion: {{ include "common.capabilities.statefulset.apiVersion" . }}
kind: StatefulSet
metadata:
  name: {{ include "mysql.secondary.fullname" . }}
  namespace: {{ include "common.names.namespace" . | quote }}
  labels: {{- include "common.labels.standard" ( dict "customLabels" .Values.commonLabels "context" $ ) | nindent 4 }}
    app.kubernetes.io/component: secondary
  {{- if .Values.commonAnnotations }}
  annotations: {{- include "common.tplvalues.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }}
  {{- end }}
spec:

[ewilkins-csi]

S: Just use one dictionary. Write the base keys first, then write the props. That will automatically cause anything duplicate values in properties to take precedence over baseProperties without complex logic.

[ewilkins-csi]

Actually I'm not really sure why we need these dictionaries at all. Can you not just do:
{{- if not hasProperty .Values.configMap.metastoreServiceConfig.properties $baseProperty.name }}

[jaebchoi]

Sorry I'm bit new to helm syntax but from what I looked at the doc it has some limitation in creating variable and function so I had to go with dicts but open to idea and see if there's easy way to do it.

is hasProperty custom method? wasn't sure it was doable, even if it was custom methods,, shouldn't hasProperty need dict to accomplish the logic?

Im trying to accomplish 3 use case,

1. add baseProperty that doesn't exist in properties
2. add properties that doesn't exist in baseProperties
3. Add properties that both exist in baseProperties and properties ( take properties as precedence )

it's bit hard to accomplish contain logic in helm because property schema is list of dict.

[jaebchoi]

I can def cut follow up ticket if this requires refactoring given that this ticket is past DPC1!

[jaebchoi]

added https://jira.boozallencsn.com/browse/AIOPS-3838 as a follow up and will be working this