Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chunker params validation: only warn instead of fail? #7588

Closed
ThomasWaldmann opened this issue May 19, 2023 · 2 comments
Closed

chunker params validation: only warn instead of fail? #7588

ThomasWaldmann opened this issue May 19, 2023 · 2 comments
Milestone
1.2.5

Comments

@ThomasWaldmann
Copy link
Member

See there: #7586
@ThomasWaldmann ThomasWaldmann added this to the 1.2.5 milestone May 19, 2023
@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented May 19, 2023 •
edited
Loading

PR #7589

ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue May 19, 2023
@ThomasWaldmann
tests: only warn about "invalid" chunker params, fixes borgbackup#7588
af042b9 
we previously allowed some weird chunker params, so we just warn
about them instead of rejecting them.

e.g. one could use super small chunk sizes. borg can do that,
but you'll end up with a huge amount of chunks and very large
hash tables (RAM usage) to manage them.

also, one can violate the min <= mask <= max chunker param condition
as in borgbackup#7586 and it will somehow work, but will likely not dedup as good
as when not violating that.

borg2 **will** reject such strange chunker params, see borgbackup#7586 for
some ideas how to "fix" your repos.
@ThomasWaldmann
Copy link
Member Author

Moved to #7590.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.5
Development

No branches or pull requests
1 participant
@ThomasWaldmann