relax chunker params validation, tests (1.2-maint) #7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## 1.2-maint #7589 +/- ##
=============================================
- Coverage 82.42% 82.33% -0.09%
=============================================
Files 38 38
Lines 10628 10632 +4
Branches 2040 2041 +1
=============================================
- Hits 8760 8754 -6
- Misses 1328 1333 +5
- Partials 540 545 +5
|
ThomasWaldmann
changed the title
we previously allowed some weird chunker params, so we just warn about them instead of rejecting them. e.g. one could use super small chunk sizes. borg can do that, but you'll end up with a huge amount of chunks and very large hash tables (RAM usage) to manage them. also, one can violate the min <= mask <= max chunker param condition as in borgbackup#7590 and it will somehow work, but will likely not dedup as good as when not violating that. borg2 **will** reject such strange chunker params, see borgbackup#7586 for some ideas how to "fix" your repos.
ThomasWaldmann
force-pushed
the
chunker-params-1.2
branch
from
af042b9 to
5cc4e3a
Compare
|
forward port: guess we only want to port the new test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.