Merge pull request #382 from borglab/python-ci

Cleanup python CI
borglab · Sep 26, 2023 · e701fe3 · e701fe3
2 parents 1d527eb + 90c0729
commit e701fe3
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml
@@ -88,20 +88,26 @@ jobs:
       - name: Python Dependencies
         run: |
           # Install dependencies for gtwrap
-          pip3 install -U setuptools numpy pyparsing pyyaml
+          pip3 install -U pip setuptools numpy pyparsing pyyaml
 
       - name: GTSAM (Linux)
         if: runner.os == 'Linux'
         run: |
-          # Install gtsam
-          git clone https://github.com/borglab/gtsam.git /home/runner/work/gtsam
-          cd /home/runner/work/gtsam
+          # Clone gtsam
+          git clone https://github.com/borglab/gtsam.git $GITHUB_WORKSPACE/gtsam
+          cd $GITHUB_WORKSPACE/gtsam
+
+          # Build & Install gtsam
           mkdir build && cd $_
           cmake -D GTSAM_BUILD_EXAMPLES_ALWAYS=OFF -DGTSAM_BUILD_PYTHON=ON ..
           sudo make -j$(nproc) install && sudo make python-install
           sudo ldconfig
+
           cd $GITHUB_WORKSPACE # go back to home directory
 
+          # Clean up after ourselves since we used `sudo`.
+          sudo rm -rf $GITHUB_WORKSPACE/gtsam
+
       - name: GTSAM (macOS)
         if: runner.os == 'macOS'
         run: |
@@ -111,6 +117,7 @@ jobs:
           mkdir build && cd $_
           cmake -D GTSAM_BUILD_EXAMPLES_ALWAYS=OFF -DGTSAM_BUILD_PYTHON=ON -DPYTHON_EXECUTABLE=/usr/local/bin/python3 ..
           make -j$(sysctl -n hw.physicalcpu) install && make python-install
+
           cd $GITHUB_WORKSPACE # go back to home directory
 
       - name: Checkout