Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NoiseModelFactorN as factor base class #383

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Use NoiseModelFactorN as factor base class #383

merged 1 commit into from
Oct 2, 2023

Conversation

varunagrawal
Copy link
Collaborator

To be consistent with recent updates, upgrading the factors to use @gchenfc's new NoiseModelFactorN base class.

@varunagrawal varunagrawal added the quick review Quick and easy PR to review label Sep 28, 2023
@varunagrawal varunagrawal self-assigned this Sep 28, 2023
gchenfc
gchenfc approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@gchenfc gchenfc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm!

@varunagrawal varunagrawal merged commit 5371cf2 into master Oct 2, 2023
12 checks passed
@varunagrawal varunagrawal deleted the update-factor-base branch October 2, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchenfc gchenfc gchenfc approved these changes

@yetongumich yetongumich Awaiting requested review from yetongumich

Assignees

@varunagrawal varunagrawal

Labels
quick review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @gchenfc