Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all the scripts #385

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix all the scripts #385

merged 2 commits into from
Oct 11, 2023

Conversation

varunagrawal
Copy link
Collaborator

Fixed some scripts which were broken because of mine and Frank's previous PRs.

Basically, I had to initialize the prior joint angles, velocities and torques.

@varunagrawal varunagrawal added the quick review Quick and easy PR to review label Oct 9, 2023
@varunagrawal varunagrawal self-assigned this Oct 9, 2023
Copy link
Member

@gchenfc gchenfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a long time since I worked on this codebase, but would utils/Initializer::ZeroValues work here?

@varunagrawal
Copy link
Collaborator Author

I thought about that but ZeroValues adds initial values for a lot more things (like twists and wrenches in the workspace). On further thought I think the overhead is worth it though, so let me update it.

@varunagrawal
Copy link
Collaborator Author

@gchenfc gentle reminder

@varunagrawal varunagrawal merged commit ac6837d into master Oct 11, 2023
12 checks passed
@varunagrawal varunagrawal deleted the fix-scripts branch October 11, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick review Quick and easy PR to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants