Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR #1868 - Get partition name based on region #1919

Closed
wants to merge 2 commits into from

Conversation

stpaditya
Copy link

Requested feature-request: Get partition name based on region.

Description: It fetches the partition name like aws, aws-cn based on the given region name.

@swetashre swetashre added the auto-label-exempt Issue will not be subject to stale-bot label Aug 21, 2020
@github-actions
Copy link

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. Because it has been longer than one year since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment to prevent automatic closure, or if the issue is already closed, please feel free to reopen it.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Aug 21, 2021
@nateprewitt nateprewitt removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Aug 23, 2021
@nateprewitt
Copy link
Contributor

Hey @stpaditya, this change actually needs to be made in our package botocore where our endpoints.json file lives. It looks like you may have tried to port some of that here. We've just merged boto/botocore#1715 to address the underlying issue and will surface it in the boto3 Session with #3060.

I'm going to close this out since the issue should be resolved. Thanks for the PR!

@nateprewitt nateprewitt removed auto-label-exempt Issue will not be subject to stale-bot needs-review labels Oct 27, 2021
@stpaditya
Copy link
Author

@nateprewitt Ok. I checked that PR. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants