Find the partition of a region #1715

jkinred · 2019-04-13T23:00:29Z

This commit implements the core functionality for a feature request
against boto3.

I implemented the method with a more verbose name. Happy to adjust if needed.

codecov-io · 2019-04-13T23:18:05Z

Codecov Report

Merging #1715 into develop will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop    #1715      +/-   ##
===========================================
- Coverage    92.42%   92.41%   -0.02%     
===========================================
  Files           53       53              
  Lines         9872     9884      +12     
===========================================
+ Hits          9124     9134      +10     
- Misses         748      750       +2

Impacted Files	Coverage Δ
botocore/session.py	`98.09% <100%> (+0.01%)`	⬆️
botocore/regions.py	`96.55% <77.77%> (-2.17%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f3892...b19476e. Read the comment docs.

shorea · 2019-10-03T13:39:26Z

@joguSD is this something that can be merged? This would be a pretty useful feature to have.

jkinred · 2019-10-14T08:58:51Z

If this is a useful feature that may be merged, I will invest some time in cleaning up the checks and rebasing.

jeking3 · 2020-02-21T23:40:25Z

I would make use of this if it was merged as well. It seems pretty useful for ARN generation.

aph3rson · 2020-03-30T20:53:34Z

+1ing this PR as well, this would be helpful for instances where the partition is necessary for certain functionality (e.g. determining console and signin URLs, which my tool depends on).

jonrau1 · 2020-04-24T02:21:15Z

Throwing another +1 into the mix. My tool, ElectricEye, relies on the partition a lot for creation resource ARNs and creating Security Hub findings. This would allow me to not have to hard-code partitions and create separate implementations per partition.

jfuss · 2020-06-11T22:02:03Z

This would be really useful for SAM as well. Is there a way we can get this merged @kyleknap or @stealthycoin?

jfuss · 2020-06-12T18:31:43Z

@nateprewitt or @joguSD might be better people to ask merge-ablity of the feature.

wong-a · 2021-05-07T18:53:00Z

Another +1! This is a useful method. What's blocking it?

yuan-bwn · 2021-05-12T17:43:08Z

+1 for visibility!
It would be really great customer can fetch this info directly from boto instead of implementing all different sorts of helper methods.

nateprewitt

Hey @jkinred, I think we've got the capacity to try to get this into an upcoming release. If you have a moment to rebase this onto the current develop branch and address the feedback, that would be very helpful. Otherwise, I'll look at building on this PR to get it ready for merging.

tests/unit/test_session.py

botocore/regions.py

This commit implements the core functionality for a feature request against `boto3`. See boto/boto3#1868.

codecov-commenter · 2021-10-25T23:53:16Z

Codecov Report

Merging #1715 (2c4c368) into develop (26528a5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1715   +/-   ##
========================================
  Coverage    95.32%   95.33%           
========================================
  Files           59       59           
  Lines        11474    11484   +10     
========================================
+ Hits         10938    10948   +10     
  Misses         536      536

Impacted Files	Coverage Δ
botocore/exceptions.py	`99.51% <100.00%> (+<0.01%)`	⬆️
botocore/regions.py	`93.81% <100.00%> (+0.33%)`	⬆️
botocore/session.py	`96.62% <100.00%> (+0.02%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26528a5...2c4c368. Read the comment docs.

nateprewitt · 2021-10-25T23:57:08Z

Thanks @jkinred, I resolved the merge issues from the last rebase, updated the error name, and added some additional tests. I think we're ready for review now, I've tagged a couple more devs to give final sign off since I've added some changes.

kyleknap

Looks good. Just had a couple of comments.

kyleknap · 2021-10-26T17:24:08Z

botocore/regions.py

@@ -142,6 +144,19 @@ def construct_endpoint(self, service_name, region_name=None, partition_name=None
            if result:
                return result

+    def get_partition_for_region(self, region_name):
+        for partition in self._endpoint_data['partitions']:
+            if region_name in partition['regions']:


We should probably see if we can reuse the _region_match method.

Cool, let me get that updated.

botocore/regions.py

kyleknap

Looks good! 🚢

jkinred mentioned this pull request Apr 14, 2019

Get partition name from region boto/boto3#1868

Closed

aph3rson mentioned this pull request Mar 30, 2020

Support defining other partitions NetSPI/aws_consoler#1

Closed

ammokhov mentioned this pull request Jul 14, 2020

added new properties aws-cloudformation/cloudformation-cli-python-plugin#107

Merged

5 tasks

nateprewitt requested changes Oct 12, 2021

View reviewed changes

tests/unit/test_session.py Show resolved Hide resolved

nateprewitt reviewed Oct 12, 2021

View reviewed changes

botocore/regions.py Outdated Show resolved Hide resolved

jkinred force-pushed the develop branch from b19476e to be96ba4 Compare October 13, 2021 04:54

jkinred added 2 commits October 25, 2021 16:17

Find the partition of a region

ae30e58

This commit implements the core functionality for a feature request against `boto3`. See boto/boto3#1868.

Re-factor tests to hit more code paths

174b849

nateprewitt force-pushed the develop branch from be96ba4 to 92c3f10 Compare October 25, 2021 23:48

nateprewitt force-pushed the develop branch from 92c3f10 to 7980272 Compare October 25, 2021 23:55

nateprewitt requested review from joguSD and kyleknap October 25, 2021 23:56

nateprewitt force-pushed the develop branch from 7980272 to 6438651 Compare October 25, 2021 23:58

nateprewitt self-requested a review October 25, 2021 23:59

nateprewitt force-pushed the develop branch from 6438651 to db5d9c9 Compare October 26, 2021 17:32

nateprewitt approved these changes Oct 26, 2021

View reviewed changes

kyleknap reviewed Oct 26, 2021

View reviewed changes

Add UnknownRegionError and additional tests

2c4c368

nateprewitt force-pushed the develop branch from db5d9c9 to 2c4c368 Compare October 26, 2021 18:55

kyleknap approved these changes Oct 27, 2021

View reviewed changes

nateprewitt merged commit 383cb3f into boto:develop Oct 27, 2021

This was referenced Oct 27, 2021

Add get_partition_for_region to Session boto/boto3#3060

Merged

FR #1868 - Get partition name based on region boto/boto3#1919

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Find the partition of a region #1715

Find the partition of a region #1715

jkinred commented Apr 13, 2019

codecov-io commented Apr 13, 2019 •

edited

Loading

shorea commented Oct 3, 2019

jkinred commented Oct 14, 2019

jeking3 commented Feb 21, 2020

aph3rson commented Mar 30, 2020

jonrau1 commented Apr 24, 2020 •

edited

Loading

jfuss commented Jun 11, 2020

jfuss commented Jun 12, 2020

wong-a commented May 7, 2021

yuan-bwn commented May 12, 2021

nateprewitt left a comment

codecov-commenter commented Oct 25, 2021 •

edited

Loading

nateprewitt commented Oct 25, 2021

kyleknap left a comment

kyleknap Oct 26, 2021 •

edited

Loading

nateprewitt Oct 26, 2021

kyleknap left a comment

Find the partition of a region #1715

Find the partition of a region #1715

Conversation

jkinred commented Apr 13, 2019

codecov-io commented Apr 13, 2019 • edited Loading

Codecov Report

shorea commented Oct 3, 2019

jkinred commented Oct 14, 2019

jeking3 commented Feb 21, 2020

aph3rson commented Mar 30, 2020

jonrau1 commented Apr 24, 2020 • edited Loading

jfuss commented Jun 11, 2020

jfuss commented Jun 12, 2020

wong-a commented May 7, 2021

yuan-bwn commented May 12, 2021

nateprewitt left a comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 25, 2021 • edited Loading

Codecov Report

nateprewitt commented Oct 25, 2021

kyleknap left a comment

Choose a reason for hiding this comment

kyleknap Oct 26, 2021 • edited Loading

Choose a reason for hiding this comment

nateprewitt Oct 26, 2021

Choose a reason for hiding this comment

kyleknap left a comment

Choose a reason for hiding this comment

codecov-io commented Apr 13, 2019 •

edited

Loading

jonrau1 commented Apr 24, 2020 •

edited

Loading

codecov-commenter commented Oct 25, 2021 •

edited

Loading

kyleknap Oct 26, 2021 •

edited

Loading