Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brupop - Apply common k8s labels to all created resources #220

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

gthao313
Copy link
Member

@gthao313 gthao313 commented Jul 7, 2022

Issue number:
#113

Description of changes:

Author: Tianhao Geng <tianhg@amazon.com>
Date:   Thu Jul 7 20:52:34 2022 +0000

    Apply common k8s labels to all created resources

    We have some of these label defined in our model package; however,
    we weren’t consistently applying those labels to all brupop created
    resources. Hence, we need improve to apply those labels to all brupop
    resources.

Testing done:
Check if all brupop resources have correct labels

Checklist

Agent

  • agent_service_account
  • agent_cluster_role
  • agent_cluster_role_binding
  • agent_daemonset

Controller

  • controller_service_account
  • controller_cluster_role
  • controller_cluster_role_binding
  • controller_deployment
  • controller_service

Apiserver

  • apiserver_service_account
  • apiserver_cluster_role
  • apiserver_cluster_role_binding
  • apiserver_auth_delegator_cluster_role_binding
  • apiserver_deployment
  • apiserver_service

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

We have some of these label defined in our model package; however,
we weren’t consistently applying those labels to all brupop created
resources. Hence, we need improve to apply those labels to all brupop
resources.
@gthao313 gthao313 marked this pull request as ready for review July 7, 2022 21:24
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It would be great if we could write a test which iterates through the yaml document and asserts that the objects we're creating all are at least labelled as managed_by/part_of brupop, but I won't block on such a test.

@gthao313 gthao313 merged commit 4ecd77d into bottlerocket-os:develop Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants