-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: add setting for configuring eventRecordQPS and eventBurst #1532
Conversation
Can you elaborate a bit more on the migration testing done? |
7986d20
to
d5e76da
Compare
Push above fix conflicts. |
d5e76da
to
85a24bf
Compare
Push above improve Test
kube-config result
|
pass event-burst argument to kubelet
pass event-qps argument to kubelet
Adds a migration for two new settings `settings.kubernetes.event-qps` and `settings.kubernetes.event-burst`
Handlebars built-in IF helper treats "0" (zero) as false. We need use `includeZero` flag to make sure IF HELPER treats "0" (zero) as true, so "0" (zero) can be passed to registryPullQPS and registryBurst.
85a24bf
to
a9d7890
Compare
Push above fix conflicts |
Issue number:
#1495
Description of changes:
Adds two new settings
kubernetes.event-qps
andkubernetes.event-burst
for configuringTesting done:
event-qps
Creating large amount of events at same time, and check how many relevant events have been logged.
Compare two argument values (smaller value and larger value ), the number of event that has been logged by smaller value will smaller than by larger value.
Step1:
event-qps = 0
unlimited (larger value)Result: 63 events have been captured and logged.
Step2:
event-qps = 1
lowest value (smaller value)Result: 42 events have been captured and logged.
Test result: The number of events by
event-qps = 1
is smaller than byevent-qps = 0
, which means settingkubernetes.event-qps
works.event-burst
Creating large amount of events at same time, and check how many relevant events have been logged.
Compare two argument values (smaller value and larger value ), the number of event that has been logged by smaller value will smaller than by larger value.
Step1:
event-burst = 100
(larger value)Run command Twice immediately.
Result: 119 events have been captured and logged.
Step2:
event-burst = 1
lowest value (smaller value)Run command Twice immediately.
Result: 64 events have been captured and logged.
Test result: The number of events by
event-burst = 1
is smaller than byevent-burst = 100
, which means settingkubernetes.event-burst
works.Migration test:
upgrade
Step1: Upgrade to v1.1.0
Step2: Specify new setting
event-qps
andevent-burst
through control containerdowngrade
Step1: Check migration binary
Step2: Downgrade to previous verison
Step3: Check if
event-qps
andevent-burst
have been removedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.