update to bottlerocket-settings-models v0.2.0 #4118
Conversation
This adds support for hostname-override-source, so we add a migration as well. Updates the external cloud provider default to use a hostname-override-source of private-dns-name to match the current behavior.
tzneal
force-pushed
the
add-hostname-override-source
branch
from
f4ce427
to
cd22011
Compare
| migrate(AddSettingsMigration(&[ | ||
| "settings.kubernetes.hostname-override-source", | ||
| ])) | ||
| } |
There was a problem hiding this comment.
Reading this, my concern is that current hosts (with no hostname-override-source set) will have their default generator behavior changed on update because we don't populate the new default value here if it's empty.
But I suppose that's not an issue because the hostname-override will have been set on first-boot and therefore the hostname-override generator won't run again and this value is meaningless.
There was a problem hiding this comment.
Yeah, hostname-override is a weird property with the way it auto-sets. For variants where that occurs, changing hostname-override-source after the instance has no effect.
There was a problem hiding this comment.
The core kit migration and moving pluto away from a setting generator has made this hard to follow.
In 1.20.x, aws-k8s-1.25+ had a hostname-override setting generator defined that would call pluto private-dns-name to generate a hostname override.
In this PR, aws-k8s-1.25+ will instead get hostname-override-source = "private-dns-name" (via storewolf and the newer defaults), which triggers the equivalent path in the newer pluto. But newer pluto will also skip over all of this if hostname-override is already set, which it would be on upgrade from an existing aws-k8s-1.25+ host.
Issue number:
Closes #
Description of changes:
This adds support for hostname-override-source, so we add a migration as well.
Depends on bottlerocket-os/bottlerocket-core-kit#59
Testing done:
Build an AMI and verified that it works correctly when overriding the hostname source.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.