-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release.toml: add migration for hostname-override-source #4127
Conversation
A Rust compiler update broke type inference on one of our dependencies, which is not covered by Rust's compiler compatability guarantee.
@@ -2655,9 +2655,9 @@ dependencies = [ | |||
|
|||
[[package]] | |||
name = "time" | |||
version = "0.3.34" | |||
version = "0.3.36" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed by the migration or is this change required to fix another problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build currently fails without this: https://github.com/bottlerocket-os/bottlerocket/actions/runs/10254923209/job/28370732469
I'm not really sure how this didn't cause previous Actions jobs to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rust-lang/rust#125319 (comment)
There was an regression introduced in time
. I was following this above issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rust compiler has weaker backwards compatibility guarantees specifically regarding type inference, so this was caused by the compiler update with the new SDK.
But I don't understand why the build in #4122 didn't also fail.
Description of changes:
Adds the migration introduced in #4118 to
Release.toml
Testing done:
settings.kubernetes.hostname-override-source
becomes present on upgradeTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.