Release.toml: add migration for hostname-override-source #4127
Conversation
A Rust compiler update broke type inference on one of our dependencies, which is not covered by Rust's compiler compatability guarantee.
| @@ -2655,9 +2655,9 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "time" | |||
| version = "0.3.34" | |||
| version = "0.3.36" | |||
There was a problem hiding this comment.
Is this change needed by the migration or is this change required to fix another problem?
There was a problem hiding this comment.
The build currently fails without this: https://github.com/bottlerocket-os/bottlerocket/actions/runs/10254923209/job/28370732469
I'm not really sure how this didn't cause previous Actions jobs to fail.
There was a problem hiding this comment.
rust-lang/rust#125319 (comment)
There was an regression introduced in time. I was following this above issue.
There was a problem hiding this comment.
The Rust compiler has weaker backwards compatibility guarantees specifically regarding type inference, so this was caused by the compiler update with the new SDK.
But I don't understand why the build in #4122 didn't also fail.
Description of changes:
Adds the migration introduced in #4118 to
Release.tomlTesting done:
settings.kubernetes.hostname-override-sourcebecomes present on upgradeTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.