Bump core kit 2.3.1 #4122
Bump core kit 2.3.1 #4122
Conversation
| source = "public.ecr.aws/bottlerocket/bottlerocket-sdk:v0.43.0" | ||
| digest = "1zKyWC/pXdpzKfNj1Xp1YvEWdyltI7EhAeiNwlikBz8=" |
There was a problem hiding this comment.
Should updates to the SDK source and digest in the lock file be included in the commit bumping the SDK?
There was a problem hiding this comment.
I think so. The build will fail if you don't update the .lock file after updating the Twoliter.toml.
There was a problem hiding this comment.
Sorry let me rephrase: Currently, the SDK source and digest updates in the lock file are included in the commit bumping the core-kit version. Should this be moved to the commit bumping the SDK version instead?
I'm not sure if this is an issue, but currently if someone just picks the SDK version update commit, the build will fail -- basically that commit is "non-atomic"
There was a problem hiding this comment.
I see what you mean. Yeah I'm not sure. I think there is some dependency between the core-kit and sdk version which requires both, the main repo and the kit to be on the same sdk version so taking just one of these changes would lead to an undefined state as well.
vigh-m
force-pushed
the
bump-core-kit-2.3.1
branch
from
dfd7ac2
to
5ee8632
Compare
|
Rebased to use the latest Twoliter version |
Description of changes:
Bump to latest core kit release v2.3.1
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.