-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrations: host-containers default version migration redux and new common migration 'ReplaceTemplateMigration' #717
Conversation
@tjkirch Now that the host-containers source is templated. What do you think is the best way to account for other possible regions on backwards migration? (Currently the images are only available in us-west-2) |
@etungsten Unfortunately we can't just check the version/suffix because customers could use the same versioning. We need to make sure the source account and version match, at least. One way would be a pattern match that reuses the source region. A simpler way would be confirming the source account matches, then just replacing the suffix. (We have all the data, so we could regenerate from the pattern using schnauzer, but that seems a bit much and assume some things...) |
@etungsten Actually, using schnauzer may not be such a bad idea. Through the Something like:
|
164022a
to
0b1f7ab
Compare
Adds new common migration helper |
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
904d323
to
8c1c601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: whether we include the concrete migration for v0.3 depends on out-of-band discussions today regarding the breaking-ness of our next release. (If it's a full break release with no upgrade, we won't need the migration.) We still want the common migration code because we'll need it soon regardless.
workspaces/api/migration/migrations/v0.2/migrate-host-containers-version-v03/Cargo.toml
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
8c1c601
to
deea57e
Compare
Addresses @tjkirch 's comments.
Tested and things still work. |
deea57e
to
261b934
Compare
Drop dependency on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please confirm/update the testing?
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
261b934
to
daf8dc1
Compare
Addresses @tjkirch 's comments. Tested new changes and things still work as expected:
Backward:
|
daf8dc1
to
599f0d8
Compare
It looks like the forward/backward testing sections are backwards? And the messages aren't symmetrical (forward was updated but not backward, or vice versa, not sure because the header seems backwards), can we fix that? [edit] Ah, I see, the force-push after the testing fixed that message. Would be nice to keep the testing in the description up to date, if it's changed, and just confirm in update-related comments that it was retested. |
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migration-helpers/src/common_migrations.rs
Outdated
Show resolved
Hide resolved
599f0d8
to
02a951a
Compare
Addressed @tjkirch 's comments. |
Adds new common migration helper 'ReplaceTemplateMigration' that updates a setting's template and then use that template to generate new data which is then set.
Adds new migration binary for bumping the default host containers version from v0.2 to v0.3. v0.3 contains IMDSv2 support and API transaction support. The migration also includes a name change for the host-container images
02a951a
to
463222f
Compare
Force push above rebases onto |
Bumps the default versions of admin and control container to version 0.3
Issue #, if available: Partially addresses #685
Description of changes:
Bumps the default version of the host container images.
Adds new common migration helper
ReplaceTemplateMigration
.Adds new migration binary for bumping the default host containers version from v0.2 to v0.3.
Testing done:
Forward migration:
Backward migration:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.