-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to Bottlerocket #722
Conversation
7b238c1
to
3acf058
Compare
As discussed separately, this push removes the change to the partition labels, instead leaving them as "THAR-*" so we don't break upgrades yet. That change will go to another PR for when we're ready to merge it. This also removes the "THAR"/"BOTTLEROCKET" filesystem labels, which were unused and potentially confusing. (I retested by remaking an AMI, running pods, etc.) |
3acf058
to
e8105ef
Compare
This push addresses some of @bcressey's comments. Retested with a new AMI. |
4641936
to
a64fedd
Compare
This push kills the crab. (sorry about the double push, it's just the "fixup" commit that I then rebased in) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dogswatch
changes look good to me - it builds and passes unit tests. I don't have the bandwidth to run the dogswatch
tests mentioned for this PR, but will follow up with the next-release testing to check that we're not broken as @tjkirch hinted at.
a64fedd
to
208bcc6
Compare
Rebased on develop to fix conflicts; this removed a couple thar/bottlerocket references thanks to Jake's changes, and I updated the licenses squashfs change to use "bottlerocket" in paths and such. Built a new AMI and pods are OK, /usr/share/licenses still works. |
iliana and I merged this with #719 and are building new SDKs; once those are uploaded we'll push the merge. |
This renames everything in the repo to Bottlerocket, except for some things listed below.
bottlerocket-admin
andbottlerocket-control
repos were created in ECR, and v0.2 and v0.3 of each image were uploaded in us-west-2 and us-east-1.Remaining work, outside this PR:
"Thar" references not updated in this PR:
Testing done:
workspaces/
unit tests pass./.thar
which isn't there anymore).Testing not done, but that will happen before next release: