-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubernetes 1.16 #919
Add Kubernetes 1.16 #919
Conversation
Cargo doesn't allow some common characters like "." in a package name, which would normally prevent you from naming package artifacts with those characters. With this change, if you specify `package.metadata.build-package.package-name` in Cargo.toml, you can override the package name and tell the build system to look at your preferred name for the package directory, spec file, etc.
The main change is adding a version to the name of the kubelet package so that the variant can pick the relevant Kubernetes version.
There are only minor changes from 1.15 packaging: * We no longer need the patch related to go module building. * The source of the go-bindata dependency changed, so clarify.toml is updated. * The new go-tools dependency needed a clarify.toml entry.
No model changes are required from aws-k8s-1.15, so the model is a symlink. The only differences from aws-k8s-1.15 are the name and the kubelet version.
This push addresses @bcressey's concern, and adds a commit with a patch updating aws-sdk-go for IMDSv2 support. I also updated the Testing Done to show sonobuoy conformance. |
I added a commit that updates documentation to reference the new aws-k8s-1.16 variant. I was going to put it in a separate PR, but because this won't be our default variant yet, the updates were minimal and I figured it was simpler to include it here. |
aws-k8s-1.15 is still the supported variant, so the documentation changes are minimal for now.
This push simplifies the documentation update, per discussion with @bcressey. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍶
This adds a Kubernetes 1.16 package and a new aws-k8s-1.16 variant that uses it.
Notes for reviewers:
packages/kubernetes-1.16
are identical to 1.15 save for:Testing done:
Built an aws-k8s-1.15 AMI, still works fine.
Built an aws-k8s-1.16 AMI, it joins my cluster and shows the new version:
A pod runs fine. System services
running
. API settings look OK.I diffed the kubelet service log between 1.15 and 1.16 and found no substantive changes, just minor bits: a number of lines were reordered, some source filenames changed, some old debug lines were removed, there's a new "fake_topology_manager", and a new (presumably related)
ExperimentalTopologyManagerPolicy:none
in the node config (which becomes not-experimental in a later k8s release).The 1.16 AMI passes Sonobuoy testing with conformance version 1.16.8 (matching EKS) in a 1.16 cluster:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.