Add aws-k8s-1.17 variant with Kubernetes 1.17 #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Jul 8, 2020
webern
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Add to CI?
bottlerocket/.github/workflows/build.yml
Line 11 in ed40a7c
There are only minor changes from the aws-k8s-1.16 variant: * Rebase the aws-sdk-go update patch * No longer need the license clarification for github.com/munnerz/goautoneg because the project added a license file * Disable new CSIMigration in kubelet-config until further supported: https://kubernetes.io/blog/2019/12/09/kubernetes-1-17-feature-csi-migration-beta/
|
^ adds 1.17 to the GitHub workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only minor changes from the aws-k8s-1.16 variant:
because the project added a license file
https://kubernetes.io/blog/2019/12/09/kubernetes-1-17-feature-csi-migration-beta/
Very little original work needed for 1.17. For reference, the addition of 1.16: #919
Testing done:
Ran with my EKS 1.16 cluster, the latest support version. System
runningand seems OK. Was able to connect to the cluster and run pods OK.While figuring out the CSIMigration thing, I diffed the kubelet output from 1.16 and found nothing surprising, other than the warning that helped me figure out CSIMigration.
Ran the sonobuoy conformance test with conformance version 1.16.8, matching EKS.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.