Avoid reading non-regular files. #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Thanks for the submission. Ill be looking into the test issues sometime soon once I get though some other things I am working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we try and read things like fifos we can block indefinitely trying to read. So we want to avoid reading them. Other non-regular files (other than directories and symlinks) are likely to also be weird in other ways.
As the code above this deals with symlinks and directories are expected to already be excluded I think skipping non-regular files is reasonable.
I couldn't get the tests to work on my machine before this change so I don't know if this passes them or not. There may be weird cases I haven't thought about that the tests cover.