Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL to recognised languages #317

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

edoardopirovano
Copy link
Contributor

Greetings, I hope you are doing well. I'm one of the language maintainers for CodeQL, a language for querying codebases in order to find vulnerabilities (which, in fact, you are using here). This PR adds CodeQL to the set of languages that scc will recognise and count lines for. Our language specification can be found here if you'd like to double check that what I have done is a sensible representation of that.

We have a slight vested interest in this since the CodeQL engine actually uses scc under the hood to do some line counting (in particular, if you go to the Security tab for a GitHub repository that is using CodeQL and you are an admin of, then click Code scanning alerts and the total number of lines under Lines scanned is coming from scc). We've recently started looking into using CodeQL to analyse our own CodeQL code, so getting this PR in would allow us to get sensible line counts for our own code there.

@boyter
Copy link
Owner

boyter commented Feb 9, 2022

Neat! I did not know

Also a very high quality PR to boot! Looks perfect to me and thank you for including a link to the language spec which makes this much easier than having to search around for it. Approved.

Should make the next version, although you can build from mainline if you need it faster.

@boyter boyter merged commit fd128bc into boyter:master Feb 9, 2022
@edoardopirovano edoardopirovano deleted the add-codeql branch February 9, 2022 08:58
@edoardopirovano
Copy link
Contributor Author

edoardopirovano commented Feb 9, 2022

Should make the next version, although you can build from mainline if you need it faster.

Thanks! We're already building from an internal fork of your last release with this patch (and also #295 which one of my colleagues wrote) applied, but it's good to get it included here so when you next do a release we can update our internal fork without having to reapply any patches.

@boyter
Copy link
Owner

boyter commented Feb 9, 2022

Ah neat. I really need to finish off the last few items in the queue. I hope to have it all done for Go 1.18 release so I can get the free performance improvements that usually brings.

@YASINE0
Copy link

YASINE0 commented Feb 13, 2022

I am a child witnessing you from Morocco. I want to learn programming from you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants