Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API client cleanup and refactoring #323

Merged
merged 23 commits into from
May 26, 2023
Merged

Conversation

bpg
Copy link
Owner

@bpg bpg commented May 5, 2023

Major refactoring of remaining parts of the API client, split into packages as per PVE API structure, trim VirtualEnvironment prefix from all names, and other cleanups.
Also enable more linter rules an address linter errors as the result.

Contributor's Note

Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /examples for any new or updated resources / data sources.
  • I have ran make examples to verify that the change works as expected.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

@bpg bpg force-pushed the continue-client-refactoring branch 2 times, most recently from 61e819f to c468a86 Compare May 11, 2023 02:17
@bpg bpg force-pushed the continue-client-refactoring branch from b63b235 to 2526da0 Compare May 22, 2023 18:23
@bpg bpg force-pushed the continue-client-refactoring branch from 2526da0 to 8c20ddb Compare May 23, 2023 22:01
@bpg bpg force-pushed the continue-client-refactoring branch from 15653f6 to 4b67228 Compare May 25, 2023 00:32
@bpg bpg changed the title WIP: API client refactoring chore: API client cleanup and refactoring May 26, 2023
@bpg bpg changed the title chore: API client cleanup and refactoring feat: API client cleanup and refactoring May 26, 2023
@bpg bpg marked this pull request as ready for review May 26, 2023 01:18
@bpg bpg force-pushed the continue-client-refactoring branch from 00cf688 to 5688e3b Compare May 26, 2023 01:31
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg enabled auto-merge (squash) May 26, 2023 01:32
@bpg bpg merged commit 1f006aa into main May 26, 2023
@bpg bpg deleted the continue-client-refactoring branch May 26, 2023 01:32
@ghost ghost mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant