-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API client cleanup and refactoring #323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpg
force-pushed
the
continue-client-refactoring
branch
2 times, most recently
from
May 11, 2023 02:17
61e819f
to
c468a86
Compare
bpg
force-pushed
the
continue-client-refactoring
branch
from
May 22, 2023 18:23
b63b235
to
2526da0
Compare
bpg
force-pushed
the
continue-client-refactoring
branch
from
May 23, 2023 22:01
2526da0
to
8c20ddb
Compare
bpg
force-pushed
the
continue-client-refactoring
branch
from
May 25, 2023 00:32
15653f6
to
4b67228
Compare
bpg
changed the title
WIP: API client refactoring
chore: API client cleanup and refactoring
May 26, 2023
bpg
changed the title
chore: API client cleanup and refactoring
feat: API client cleanup and refactoring
May 26, 2023
bpg
force-pushed
the
continue-client-refactoring
branch
from
May 26, 2023 01:31
00cf688
to
5688e3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 LGTM! beep boop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of remaining parts of the API client, split into packages as per PVE API structure, trim
VirtualEnvironment
prefix from all names, and other cleanups.Also enable more linter rules an address linter errors as the result.
Contributor's Note
Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.
/docs
for any user-facing features or additions./examples
for any new or updated resources / data sources.make examples
to verify that the change works as expected.Community Note
Relates OR Closes #0000