Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feel-popup): include feel popup module #975

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat(feel-popup): include feel popup module #975

merged 1 commit into from
Sep 22, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Sep 22, 2023 •
edited
Loading

Closes #974

Adds the core feelPopup module to interact with the FEEL popup editor in a non-UI manner.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 22, 2023
@pinussilvestrus pinussilvestrus mentioned this pull request Sep 22, 2023
Merged
nikku
nikku reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

test/spec/BpmnPropertiesPanelRenderer.spec.js
});


withPropertiesPanel('>=3.7')('#isOpen', async function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@pinussilvestrus pinussilvestrus marked this pull request as ready for review September 22, 2023 12:25
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 22, 2023
@pinussilvestrus
Copy link
Contributor Author

@bpmn-io/modeling-dev This is ready for review now.

@pinussilvestrus pinussilvestrus requested review from a team, philippfromme, marstamm and nikku and removed request for a team September 22, 2023 12:25
nikku
nikku approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff.

@nikku nikku merged commit d251de0 into main Sep 22, 2023
7 checks passed
@nikku nikku deleted the 974-feel-popup-api branch September 22, 2023 12:42
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 22, 2023
@nikku nikku mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@marstamm marstamm Awaiting requested review from marstamm marstamm was automatically assigned from bpmn-io/modeling-dev

Assignees

@pinussilvestrus pinussilvestrus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be able to hook into FEEL popup life-cycle via events
2 participants
@pinussilvestrus @nikku