Feel Popup event support

[pinussilvestrus]

Related to bpmn-io/bpmn-js-properties-panel#974

This provides the capability to hook into the feel popup lifecycle as

• feelPopup.opened
• feelPopup.closed
• feelPopup._open
• feelPopup._close
• feelPopup._isOpen

Furthermore, this adds a feature service that integrators can use to interact with the popup. Cf. to this example on how to use it. I didn't add particular test coverage for this module in this project similar to debounceInput as I saw we do not have a proper didi-like test setup in the core framework.

const feelPopup = bpmnjs.get('feelPopup');

console.log('is open', feelPopup.isOpen());

feelPopup.close();

feelPopup.open(someElement, { type: 'feel' }, elementToRestoreFocusAfterClose);

Happy to receive your feedback ❤️ @bpmn-io/modeling-dev @bpmn-io/hto-dev

[nikku]

If we want to keep backwards compatibility then we'd need to make eventBus optional.

[nikku]

This looks great. One last question: Do we need to make eventBus an optional dependency at the core?

Should be a comment

[pinussilvestrus]

I liked the null-object pattern usage here, so I used that via 0abe5d7. 🏆

I believe that is okay, as eventBus is optional in the parent PropertiesPanel component as well (at least from the JSDocs 🙂)

[nikku]

Great stuff.

[pinussilvestrus]

I'd take over releasing these bits and open up bpmn-io/bpmn-js-properties-panel#975 if that's okay to you.

[nikku]

That's great, thank you :)