Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering Bug When Moving Boundary Event Results in Replace #1207

Closed
philippfromme opened this issue Oct 2, 2019 · 1 comment · Fixed by #1223
Closed

Ordering Bug When Moving Boundary Event Results in Replace #1207

philippfromme opened this issue Oct 2, 2019 · 1 comment · Fixed by #1223
Labels
bug Something isn't working
Milestone
M31

Comments

@philippfromme
Copy link
Contributor

When moving a boundary event results in a replace the boundary event is behind its host afterward.

ordering-bug
@philippfromme philippfromme added bug Something isn't working backlog Queued in backlog labels Oct 2, 2019
@philippfromme
Copy link
Contributor Author

philippfromme commented Oct 10, 2019 •
edited
Loading

Hint: This bug occurs due to the fact that the ID of the replaced event is kept. When elements.changed is fired the use of uniqueBy results in the replaced element being referenced, not the replacement. This can be fixed by reversing the changed elements before using uniqueBy.

philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Oct 10, 2019
@philippfromme
fix(command): return latest changed elements
5809582 
Related to bpmn-io/bpmn-js#1207
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Oct 10, 2019
@philippfromme
fix(command): return latest changed elements
0716aac 
Related to bpmn-io/bpmn-js#1207
@philippfromme philippfromme mentioned this issue Oct 10, 2019
Merged
@philippfromme philippfromme added needs review Review pending in progress Currently worked on and removed backlog Queued in backlog needs review Review pending labels Oct 10, 2019 — with bpmn-io-tasks
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 11, 2019
@philippfromme @fake-join
fix(command): return latest changed elements
f312b78 
Related to bpmn-io/bpmn-js#1207
barmac pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 11, 2019
@philippfromme @barmac
fix(command): return latest changed elements
fd24592 
Related to bpmn-io/bpmn-js#1207
@philippfromme philippfromme added the fixed upstream Requires integration of upstream change label Oct 11, 2019
@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed in progress Currently worked on labels Oct 11, 2019 — with bpmn-io-tasks
@nikku nikku removed the ready Ready to be worked on label Oct 15, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M31 milestone Oct 15, 2019
oguzeroglu pushed a commit that referenced this issue Oct 16, 2019
chore(project): bump diagram-js version
93462e6 
Closes #1207
@oguzeroglu oguzeroglu mentioned this issue Oct 16, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Oct 16, 2019
@fake-join fake-join bot closed this as completed in #1223 Oct 16, 2019
fake-join bot pushed a commit that referenced this issue Oct 16, 2019
@fake-join
chore(project): bump diagram-js version
6f451e4 
Closes #1207
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 16, 2019
@pinussilvestrus pinussilvestrus mentioned this issue Oct 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
M31
Development

Successfully merging a pull request may close this issue.

chore(project): bump diagram-js version bpmn-io/bpmn-js
3 participants
@nikku @philippfromme @pinussilvestrus