Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(command): return latest changed elements #419

Merged
merged 1 commit into from
Oct 11, 2019
Merged

fix(command): return latest changed elements #419

merged 1 commit into from
Oct 11, 2019

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Oct 10, 2019 •
edited
Loading

Scenario

  1. Command handler A returns dirty shape A with ID foo
  2. Command handler B returns dirty shape B with ID foo
  3. elements.changed will be fired with shape A even though the latest changed element with ID foo was shape B

Replacement (while keeping the ID) is one of the cases where this becomes a problem.

Related to bpmn-io/bpmn-js#1207.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 10, 2019
@philippfromme philippfromme requested a review from barmac October 10, 2019 12:24
@philippfromme philippfromme mentioned this pull request Oct 10, 2019
Merged
@fake-join fake-join bot merged commit f312b78 into develop Oct 11, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 11, 2019
@fake-join fake-join bot deleted the commandstack-fix branch October 11, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @barmac