[CLOSED] Close Live Development when switching projects

[core-ai-bot]

Issue by redmunds
Wednesday Apr 17, 2013 at 21:01 GMT
Originally opened as adobe/brackets#3469

---

Old Title: Verify server provider matches project when switching documents

This is for #3410.

The server provider is not automatically updated when switching projects , so we need to detect that case. Keeping Live Dev open across projects seems a bit weird anyway, so it's easiest to just close it.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/3469/commits

[core-ai-bot]

Comment by redmunds
Wednesday Apr 17, 2013 at 21:14 GMT

---

@jasonsanjose Your change in pull request adobe/brackets#3442 doesn't fix the problem for me. Can you review this one?

[core-ai-bot]

Comment by RaymondLim
Wednesday Apr 17, 2013 at 21:28 GMT

---

@redmunds
I just confirmed that your changes fix issue #3410.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Apr 17, 2013 at 21:49 GMT

---

Assigned to me

[core-ai-bot]

Comment by jasonsanjose
Wednesday Apr 17, 2013 at 21:56 GMT

---

Hmm...I don't see why this fix/bug would be windows specific. Am I missing something?

[core-ai-bot]

Comment by jasonsanjose
Wednesday Apr 17, 2013 at 22:12 GMT

---

I feel like the more appropriate fix is simpler, add a beforeProjectClose listener to ProjectManager and call LiveDevelopment.close(). I can't think of many reasons to keep the connection open. Even if we do, we don't have the infrastructure to support that.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Apr 17, 2013 at 22:14 GMT

---

@redmunds what do you think?@gruehle and I agree on closing live preview when switching projects. Any objections?

[core-ai-bot]

Comment by redmunds
Wednesday Apr 17, 2013 at 22:39 GMT

---

@jasonsanjose@gruehle Stopping Live Dev on project change sounds good to me. I'll let you know when I push my changes.

[core-ai-bot]

Comment by redmunds
Thursday Apr 18, 2013 at 02:11 GMT

---

@jasonsanjose changes pushed.

[core-ai-bot]

Comment by jasonsanjose
Thursday Apr 18, 2013 at 03:56 GMT

---

Much better. :) Merging.