Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix live development connection in Chrome 27 beta #3442

Merged
merged 5 commits into from
Apr 18, 2013

Conversation

jasonsanjose
Copy link
Member

Fix for #3402

  • Change Inspector domain methods to return a promise if no explicit callback parameter is defined
  • Force Page domain to load prior to loading other agents (some agents wait for Page loadEventFired event...yes the name is from the department of redundancy department)
  • Wait for domain enable calls to complete before agent loading continues
  • Misc event handler cleanup

@njx can you retest on mac w/ chrome 27? I've tested mac Chrome 26 and win Chrome 27.

…nce. Add fallback promise to inspector method calls without explicit callback.
@redmunds
Copy link
Contributor

I'm having a problem in Chrome Version 26.0.1410.64 m (not 27 beta) on Win7. CSS updates correctly while typing and I can update (and save) HTML, but only once. After that non of my HTML edits are reflected in Chrome (but CSS still updates). This happens with both builtin node js server and Base Url (with local wamp server).

In console, I am seeing lots of errors: Failed to load resource http://127.0.0.1:9222/json and ConsoleAgent: Port error: Could not establish connection. Receiving end does not exist. in chromeHidden.Port.dispatchOnDisconnect:17.

@jasonsanjose
Copy link
Member Author

I'm trying to retest with Chrome 26 on windows, but I've somehow gotten to a state where Brackets won't even launch Chrome for live preview. I may have to ditch my VM and start over.

@redmunds
Copy link
Contributor

Looks good. Merging.

redmunds added a commit that referenced this pull request Apr 18, 2013
Fix live development connection in Chrome 27 beta
@redmunds redmunds merged commit db1bdbe into master Apr 18, 2013
@redmunds redmunds deleted the jasonsanjose/issue-3402 branch April 18, 2013 02:13
@jasonsanjose
Copy link
Member Author

I was finally able to retest and confirm the fix on windows chrome 26.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants