Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Close Live Development when switching projects #3469

Merged
merged 3 commits into from
Apr 18, 2013
Merged

Conversation

redmunds
Copy link
Contributor

Old Title: Verify server provider matches project when switching documents

This is for #3410.

The server provider is not automatically updated when switching projects , so we need to detect that case. Keeping Live Dev open across projects seems a bit weird anyway, so it's easiest to just close it.

@redmunds
Copy link
Contributor Author

@jasonsanjose Your change in pull request #3442 doesn't fix the problem for me. Can you review this one?

@RaymondLim
Copy link
Contributor

@redmunds
I just confirmed that your changes fix issue #3410.

@ghost ghost assigned jasonsanjose Apr 17, 2013
@jasonsanjose
Copy link
Member

Assigned to me

@jasonsanjose
Copy link
Member

Hmm...I don't see why this fix/bug would be windows specific. Am I missing something?

@jasonsanjose
Copy link
Member

I feel like the more appropriate fix is simpler, add a beforeProjectClose listener to ProjectManager and call LiveDevelopment.close(). I can't think of many reasons to keep the connection open. Even if we do, we don't have the infrastructure to support that.

@jasonsanjose
Copy link
Member

@redmunds what do you think? @gruehle and I agree on closing live preview when switching projects. Any objections?

@redmunds
Copy link
Contributor Author

@jasonsanjose @gruehle Stopping Live Dev on project change sounds good to me. I'll let you know when I push my changes.

@redmunds
Copy link
Contributor Author

@jasonsanjose changes pushed.

@jasonsanjose
Copy link
Member

Much better. :) Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants