This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Close Live Development when switching projects #3469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jasonsanjose Your change in pull request #3442 doesn't fix the problem for me. Can you review this one? |
ghost
assigned jasonsanjose
Apr 17, 2013
Assigned to me |
Hmm...I don't see why this fix/bug would be windows specific. Am I missing something? |
I feel like the more appropriate fix is simpler, add a |
@jasonsanjose @gruehle Stopping Live Dev on project change sounds good to me. I'll let you know when I push my changes. |
@jasonsanjose changes pushed. |
Much better. :) Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Apr 18, 2013
Close Live Development when switching projects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old Title: Verify server provider matches project when switching documents
This is for #3410.
The server provider is not automatically updated when switching projects
, so we need to detect that case. Keeping Live Dev open across projects seems a bit weird anyway, so it's easiest to just close it.