Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignore-paths #91

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Sep 18, 2020

Do not perform any auth check if the request path matches any specified by the new ignore-paths flag, just proxy. Closes #25

I think this can live alongside --allow-paths but interested to hear your thoughts.

@brancz
Copy link
Owner

brancz commented Sep 21, 2020

cc @s-urbaniak @simonpasquier

main.go Show resolved Hide resolved
Do not perform any auth check if the request path matches any specified by the
new ignore-paths flag.
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@s-urbaniak
Copy link
Collaborator

This looks great, thank you for the contribution! LGTM too 🎉

@s-urbaniak s-urbaniak merged commit d4c40ad into brancz:master Sep 22, 2020
ibihim pushed a commit to ibihim/kube-rbac-proxy that referenced this pull request Mar 1, 2024
…hift-4.16-kube-rbac-proxy

OCPBUGS-29974: Updating kube-rbac-proxy-container image to be consistent with ART for 4.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support workloads with http probes
4 participants