*: move to klog v2 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How come no tests were run against this? 🤔 |
|
They were, but travis didn't report them back: https://travis-ci.org/github/brancz/kube-rbac-proxy/builds/733627457. There seems to be a flaky e2e test. Maybe we should move to github actions? |
|
Happy to move to github actions, but in a separate PR I would say. I retriggered the build. |
|
lgtm on green |
|
agreed with all above, lgtm too 👍 |
This was referenced Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to klog v2 for compatibility reasons.
cc @s-urbaniak