#1538 Tax remove constant symbol (#1733)

* Remove constant symbol from tax payment data on FE * Remove constant symbol from payment QR code --------- Co-authored-by: Marek Bodinger <marek.bodinger@gmail.com>
bratislava · Nov 11, 2024 · f87908e · f87908e
1 parent 76dabae
commit f87908e
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 14 deletions.
diff --git a/nest-tax-backend/kubernetes/envs/Dev/.env b/nest-tax-backend/kubernetes/envs/Dev/.env
@@ -14,8 +14,7 @@ PAYGATE_PAYMENT_REDIRECT_URL=https://test.3dsecure.gpwebpay.com/pgw/order.do
 PAYGATE_REDIRECT_URL=https://nest-tax-backend.dev.bratislava.sk/payment/cardpay/response
 
 PAYMENT_QR_IBAN=SK3175000000000025747653
-PAYMENT_QR_CONSTANT_SYMBOL=8148
 
 PAYGATE_AFTER_PAYMENT_REDIRECT_FRONTEND=https://city-account-next.dev.bratislava.sk/platba/stav
 
-BLOOMREACH_API_URL=https://api.eu1.exponea.com
+BLOOMREACH_API_URL=https://api.eu1.exponea.com
diff --git a/nest-tax-backend/kubernetes/envs/Prod/.env b/nest-tax-backend/kubernetes/envs/Prod/.env
@@ -15,7 +15,6 @@ PAYGATE_PAYMENT_REDIRECT_URL=https://3dsecure.gpwebpay.com/pgw/order.do
 PAYGATE_REDIRECT_URL=https://nest-tax-backend.bratislava.sk/payment/cardpay/response
 
 PAYMENT_QR_IBAN=SK3175000000000025747653
-PAYMENT_QR_CONSTANT_SYMBOL=8148
 
 PAYGATE_AFTER_PAYMENT_REDIRECT_FRONTEND=https://konto.bratislava.sk/platba/stav
 

diff --git a/nest-tax-backend/kubernetes/envs/Staging/.env b/nest-tax-backend/kubernetes/envs/Staging/.env
@@ -15,7 +15,6 @@ PAYGATE_PAYMENT_REDIRECT_URL=https://test.3dsecure.gpwebpay.com/pgw/order.do
 PAYGATE_REDIRECT_URL=https://nest-tax-backend.staging.bratislava.sk/payment/cardpay/response
 
 PAYMENT_QR_IBAN=SK3175000000000025747653
-PAYMENT_QR_CONSTANT_SYMBOL=8148
 
 PAYGATE_AFTER_PAYMENT_REDIRECT_FRONTEND=https://city-account-next.staging.bratislava.sk/platba/stav
 

diff --git a/nest-tax-backend/src/utils/subservices/qrcode.subservice.ts b/nest-tax-backend/src/utils/subservices/qrcode.subservice.ts
@@ -17,7 +17,6 @@ export class QrCodeSubservice {
           amount: qrCodeData.amount / 100,
           bankAccounts: [{ iban: process.env.PAYMENT_QR_IBAN }],
           currencyCode: 'EUR',
-          constantSymbol: process.env.PAYMENT_QR_CONSTANT_SYMBOL,
           variableSymbol: qrCodeData.variableSymbol,
           specificSymbol: qrCodeData.specificSymbol,
         },

diff --git a/next/components/forms/segments/AccountSections/TaxesFeesSection/PaymentData.tsx b/next/components/forms/segments/AccountSections/TaxesFeesSection/PaymentData.tsx
@@ -65,7 +65,6 @@ const Details = () => {
                 </div>
               </div>
             </div>
-            <div className="hidden h-0.5 w-full bg-gray-200 sm:block" />
             <div className="isolate flex flex-col items-start gap-1 self-stretch">
               <div className="text-p2">{t('bank_info.csob')}</div>
               <div className="flex w-full">
@@ -76,12 +75,13 @@ const Details = () => {
               </div>
             </div>
             <div className="hidden h-0.5 w-full bg-gray-200 sm:block" />
-            <div className="flex flex-col items-start gap-2">
-              <div className="grid grid-cols-1 gap-1 lg:grid-cols-2 lg:gap-2">
-                <div className="text-16-semibold lg:mr-4">{t('constant_symbol')}</div>
-                <div className="text-16 mb-1 lg:mb-0">{t('constant_symbol_number')}</div>
-                <div className="text-16-semibold lg:mr-4">{t('variable_symbol')}</div>
-                <div className="text-16">{taxData?.variableSymbol}</div>
+            <div className="isolate flex flex-col items-start gap-1 self-stretch">
+              <div className="text-p2">{t('variable_symbol')}</div>
+              <div className="flex w-full">
+                <div className="text-16-semibold grow">{taxData?.variableSymbol}</div>
+                <div className="hidden size-6 cursor-pointer sm:block">
+                  <ClipboardCopy copyText={taxData?.variableSymbol} />
+                </div>
               </div>
             </div>
             <div className="hidden h-0.5 w-full bg-gray-200 sm:block" />

diff --git a/next/public/locales/sk/account.json b/next/public/locales/sk/account.json
@@ -571,8 +571,6 @@
   "land_tax": "Daň z pozemkov",
   "apartments_tax": "Daň z bytov",
   "payment_data": "Platobné metódy a spôsob oznámenia výšky dane",
-  "constant_symbol": "Konštantný symbol",
-  "constant_symbol_number": "8148",
   "variable_symbol": "Variabilný symbol",
   "tax_due": "Splatnosť dane",
   "card_payment": "Platba kartou",