updated dockerfile for nest-forms-backend to new version #1400
Conversation
skifahrer
changed the title
…ckend' into updated-docker-image-on-forms-backend
…ckend' into updated-docker-image-on-forms-backend
|
Tested on dev cluster and forms-backend successfully started |
nest-forms-backend/Dockerfile
Outdated
| # production | ||
| FROM base AS prod | ||
| # Install Playwright dependencies | ||
| RUN npx playwright install-deps chromium |
There was a problem hiding this comment.
Does this needs to be present for the build step also or just for the run? If just for the run I would push it to line 28, just before prisma generate
There was a problem hiding this comment.
I noticed that I marked in the previous comment a wrong lines. But the question still stands is this needed also for build stage or can it be just part of the application and installed in app-base stage?
There was a problem hiding this comment.
When marek introduced this change he said that it needs to be present during build. But I will test if it is still ok in app-base
nest-forms-backend/Dockerfile
Outdated
| FROM base AS build-base | ||
| # Make forms-shared available | ||
| WORKDIR /forms-shared | ||
| COPY --from=shared /app/ ./ |
There was a problem hiding this comment.
Moreover, do we need entire /app directory with node_modules and everything? Wouldn't just /app/dist/ be enough?
dist has just 7.2Mb and node_modules has 1.2Gb. It would be a lot less coping and if we could just limit it files that we only need.
There was a problem hiding this comment.
I understand that you tested with removing from here and from the prod stage. So that means that it needs node_modules for actual run of the application. But as I'm looking at the https://github.com/bratislava/konto.bratislava.sk/actions/runs/10992601218/job/30517938642#step:19:1819 it seems that the docker was built successfully. So, that means that we can probably have here just
COPY --from=shared /app/dist /forms-shared/distand then have in the prod stage copy the app.
nest-forms-backend/Dockerfile
Outdated
|
|
||
| ENTRYPOINT npx prisma migrate deploy && npm run start:prod | ||
| COPY --chown=node:node --from=shared /app/ /home/node/forms-shared |
There was a problem hiding this comment.
Same as above comment here. Do we need entire /app directory with everything? Can't we just copy a part of it like just dist?
There was a problem hiding this comment.
I tested it a few times, but it didn't work. The way the forms-shared module is included in the nest-forms-backend doesn't allow us to strip node_modules from forms-shared. For example, here's a run where /app/dist was used in prod build, and it failed when did run due to missing node_modules in forms-shared.
https://github.com/bratislava/konto.bratislava.sk/actions/runs/10992601218/job/30517938642#step:19:1819
There was a problem hiding this comment.
Ok, that is fine then. I would still like to just specifically copy over only the files we need. I guess in this case it would be dist and node_modules (?) rather then entire /app folder.
github-actions
bot
added
pr: needs work 🛠️
…ckend' into updated-docker-image-on-forms-backend
|
Test build pipeline info 🚀 🔜 nest-forms-backend |
This pull request updates the old
Dockerfile. The new Dockerfile is based on thenest-prisma-templatewith some specific requirements fornest-forms-backend.