Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wording for Safety Check #12008

Closed
srirambv opened this issue Oct 6, 2020 · 2 comments · Fixed by brave/brave-core#6892
Closed

Change wording for Safety Check #12008

srirambv opened this issue Oct 6, 2020 · 2 comments · Fixed by brave/brave-core#6892
Assignees
@rebron
Labels
feature/settings feature/user-interface All UI related needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.18.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2020 •
edited by bsclifton
Loading

Test plan

  1. View brave://settings
  2. Text should say Brave can help keep you safe from unsafe websites, bad extensions, and more

Description

@fmarier comment from #11741 (comment)

Screenshot from 2020-10-05 14-00-28
which needs to be modified because we don't currently offer any data breach notifications (though we want to in #12001).

I'd suggest the following:

Brave can help keep you safe from malicious websites, bad extensions and more
@srirambv srirambv mentioned this issue Oct 6, 2020
Closed
@rebron rebron added needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 6, 2020
@rebron rebron self-assigned this Oct 6, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 7, 2020

@0xedward Interested in grabbing this one too?

@rebron rebron removed the suggestion label Oct 7, 2020
0xedward added a commit to 0xedward/brave-core that referenced this issue Oct 19, 2020
@0xedward
Update Safety check description text on brave://settings
a2e411d 
Change "Brave can help keep you safe from data breaches, bad extensions and more" to "Brave can help keep you safe from malicious websites, bad extensions, and more" for Desktop and Android

Fix brave/brave-browser#12008
@0xedward 0xedward mentioned this issue Oct 19, 2020
Merged
33 tasks
@bsclifton bsclifton added this to the 1.18.x - Nightly milestone Oct 23, 2020
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 23, 2020
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 23, 2020 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Verification passed on

Brave 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Ubuntu 18.04 LTS

Issue is still reproducible. Check #12859 for follow up:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebron rebron

Labels
feature/settings feature/user-interface All UI related needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Update Safety check description text on brave://settings 0xedward/brave-core
5 participants
@bsclifton @rebron @srirambv @btlechowski @GeetaSarvadnya