Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #12008 - Change wording for Safety Check #12859

Closed
GeetaSarvadnya opened this issue Nov 23, 2020 · 2 comments
Closed

Follow up of #12008 - Change wording for Safety Check #12859

GeetaSarvadnya opened this issue Nov 23, 2020 · 2 comments
Assignees
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/settings feature/user-interface All UI related needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@GeetaSarvadnya
Copy link

Description

@fmarier comment from #11741 (comment)

Steps to Reproduce

  1. Please refer Change wording for Safety Check #12008 and test plan Update Safety check description text on brave://settings brave-core#6892

Actual result:

The updated text Brave can help keep you safe from unsafe websites, bad extensions, and more isn't shown for the Safety check
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Windows 10 OS Version 2004 (Build 19041.630)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bsclifton @fmarier

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 24, 2020
@rebron rebron self-assigned this Nov 24, 2020
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P3 Backlog in General May 28, 2024
@Saoiray
Copy link

Saoiray commented Jun 20, 2024

@rebron I see you had movement here a bit ago. Not sure if should create a new issue or reply here, but wanted to point out an issue with current phrasing and setup for Safety Check UI.

If we go to brave://settings/privacy it will show Safety Check on the bottom. On mine, it mentioned something about Brave having password recommendations.

image

When I click on it, I'm taken to brave://settings/safetyCheck but then there's nothing said about passwords.

image

I also want to point out that the links in the above screenshot need adjusted as well. For example:
image

Clicking on Brave warns you relays to https://support.brave.com/ which then redirected for me over to https://support.brave.com/hc/en-us I would think it should go to a direct article.

In fact, all links on that page goes to that and doesn't actually show anything particular about what it's saying.

image

@fmarier
Copy link
Member

fmarier commented Jun 21, 2024

Closing since Safety Check has changed significantly in upstream Chromium. The warning from #12859 (comment) is tracked in #39212.

@fmarier fmarier closed this as completed Jun 21, 2024
@github-project-automation github-project-automation bot moved this from P3 Backlog to Completed in General Jun 21, 2024
@fmarier fmarier added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jun 21, 2024
@rebron rebron removed this from General Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/settings feature/user-interface All UI related needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants