-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement earn and give onboarding flow #12138
Comments
Rewards onboarding tour will be implemented in #12459 |
Clarifying questions:
|
FIrst load of the panel/page. When user click on start or dismiss it we should not show it again. If user has already ads on we don't show this onboarding. For example if user sees this dialog in the panel and click dismiss or start when the go to tipping banner it should not be shown again.
It enables ads and ac |
@NejcZdovc It seems like we'll need a pref to store whether the user has seen and interacted with the onboarding modal, unless you think there's a better way? |
perf should work yes |
Could you add |
label added |
Verification passed on
Rewards Panel (dismissing case)
Rewards panel (opting-in case)Inline tipping (dismissing case)
Inline tipping (opting-in case)
Rewards page (dismissing case)
|
@zenparsing Test plan needs to update for the case "Inline tipping (dismissing case)" and "Rewards page (dismissing case)"
In the above cases, the onboarding modal should be displayed upon clicking on the BR panel, as rewards is not opt-in. Correct me if I am wrong. |
@GeetaSarvadnya Thanks for pointing this out - the behavior was changed slightly in a subsequent PR (brave/brave-core#7135). I'll fix the test plan. |
@zenparsing Awesome!!!. Thanks for the quick response. |
No description provided.
The text was updated successfully, but these errors were encountered: