-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rewards everywhere onboarding #7050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenparsing
force-pushed
the
ksmith-rewards-onboarding
branch
5 times, most recently
from
November 9, 2020 15:42
d30ed00
to
3f7af77
Compare
zenparsing
force-pushed
the
ksmith-rewards-onboarding
branch
2 times, most recently
from
November 9, 2020 19:05
ef02004
to
f41277b
Compare
emerick
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NejcZdovc
reviewed
Nov 10, 2020
zenparsing
force-pushed
the
ksmith-rewards-onboarding
branch
from
November 10, 2020 14:27
911f9e9
to
785384c
Compare
Updates:
|
tmancey
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
NejcZdovc
approved these changes
Nov 10, 2020
MacOS CI failed on unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#12138
Adds rewards onboarding modals to:
Implementation notes (C++):
kOnboarded
, stored as a time value) was added to store whether a user had interacted with the onboarding experience. The onboarding modals are not displayed when this preference is not null.RewardsService
bool ShouldShowOnboarding()
: returns true if the rewards onboarding UX should be shown to the user.void SaveOnboardingResult(OnboardingResult result)
: sets thekOnboarded
pref and optionally turns on both AC and ads (ifresult
isOnboardingResult::kOptedIn
).Implementation notes (front-end):
shared/components/onboarding
.tip/lib
andtip/components
intoshared/lib
andshared/components
, respectively.WithThemeVariables
was added to inject brave theme variables as CSS custom properties.LocalContext.Provider
andWithThemeVariables
was added to the rewards panel and rewards page top-level components.store.ui.onBoardingDisplayed
was renamed tostore.ui.verifyOnboardingDisplayed
to avoid naming confusion.Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
Rewards Panel (dismissing case):
Rewards panel (opting-in case):
Inline tipping (dismissing case):
Verify that the onboarding modal is not displayed.(Modified in Improve rewards onboarding experience #7135)Inline tipping (opting-in case):
Rewards page (dismissing case):
Verify that the onboarding modal is not displayed.(Modified in Improve rewards onboarding experience #7135)Rewards page (opting-in case):
Reviewer Checklist:
After-merge Checklist:
changes has landed on.