[Desktop] tipping banners do not show messaging for creators not being able to accept tips

[LaurenWags]

Description

In 1.16.x if a creator is verified but not KYC'd, the panel and tipping banners show messaging indicating this:

NOTE: This Brave Verified Creator has not yet configured their account to receive contributions from Brave users. Your browser will keep trying to contribute until they verify, or until 90 days have passed.Learn more.

In 1.17.x only the panel shows this message, the tip banners do not.

Probably due to #11393

Steps to Reproduce

1. Clean profile 1.17.x (staging env), enable rewards
2. Connect KYC'd uphold account
3. Navigate to a Brave verified publisher who is not KYCd. ex. reddit.com/user/jsadler-brave, youtube.com/user/jjdsampson, duckduckgo.com

Actual result:

Tip banners do not show expected message:

Expected result:

Tip banners should show same message as panel:

For reference, this is what the banner looked like on 1.16.x:

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.17.53 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

• Can you reproduce this issue with the current release? not with 1.16.x
• Can you reproduce this issue with the beta channel? yes 1.17.x
• Can you reproduce this issue with the nightly channel? yes 1.18.x

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @zenparsing @NejcZdovc

[zenparsing]

Possibly an issue with the logic in showUnverifiedNotice here.

[LaurenWags]

Removing QA/Blocked, this is available for testing in https://github.com/brave/brave-browser/releases/tag/v1.17.60

[LaurenWags]

Verified passed with

Brave | 1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
-- | --
Revision | 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified STR from #12362 (comment) using staging env.
Verified scenarios outlined in brave/brave-core#6983 (comment).

1. Visit non-verified creator with Uphold wallet connected

Visited non-verified creator (ex. google.com). Confirmed messaging on panel and in banners:

Tipped publisher and confirmed tip shows in Pending list:

2. Visit verified, not KYC'd creator with Uphold wallet connected

Visited verified, non-KYC'd creator (ex. youtube.com/user/jjdsampson). Confirmed messaging on panel and in banners:

Tipped publisher and confirmed tip shows in Pending list:

3. Visit verified, KYC'd creator with Uphold wallet connected

Visited verified, KYC'd creator (ex. github.com/laurenwags). Confirmed no messaging on panel or on banners:

Tipped publisher and confirmed tip went thru:

4. Visit non-verified creator with anon wallet connected

Visited non-verified creator (ex. nytimes.com). Confirmed messaging on panel and in banners:

Tipped publisher and confirmed tip shows in Pending list:

5. Visit verified, not KYC'd creator with anon wallet connected

Visited verified, non-KYC'd creator (ex. youtube.com/user/jjdsampson). Confirmed no messaging on panel or on banners:

Tipped publisher and confirmed tip went thru:

6. Visit verified, KYC'd creator with anon wallet connected

Visited verified, KYC'd creator (ex. github.com/laurenwags). Confirmed no messaging on panel or on banners:

Tipped publisher and confirmed tip went thru:

---

Verification passed on

Brave | 1.17.68 Chromium: 87.0.4280.49 (Official Build) (64-bit)
-- | --
Revision | f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS | Windows 10 OS Version 2004 (Build 19041.572)

Verified STR from #12362 (comment) using staging env.
Verified scenarios outlined in brave/brave-core#6983 (comment).

1. Visit non-verified creator with Uphold wallet connected

Visited non-verified creator (ex. google.com). Confirmed messaging on panel and in banners:

Tipped publisher and confirmed tip shows in Pending list:

2. Visit verified, not KYC'd creator with Uphold wallet connected

Visited verified, non-KYC'd creator (ex. youtube.com/user/jjdsampson). Confirmed messaging on the panel and in banners:

Tipped publisher and confirmed tip shows in Pending list:

3. Visit verified, KYC'd creator with Uphold wallet connected

Visited verified, KYC'd creator (ex. github.com/laurenwags). Confirmed no messaging on panel or on banners:

Tipped publisher and confirmed tip went thru:

4. Visit non-verified creator with anon wallet connected

Visited non-verified creator (ex. nytimes.com). Confirmed messaging on panel and in banners:

Tipped publisher and confirmed tip shows in Pending list:

5. Visit verified, not KYC'd creator with anon wallet connected

Visited verified, non-KYC'd creator (ex. youtube.com/user/jjdsampson). Confirmed no messaging on panel or on banners:

Tipped publisher and confirmed tip went thru:

6. Visit verified, KYC'd creator with anon wallet connected

Visited verified, KYC'd creator (ex. github.com/laurenwags). Confirmed no messaging on panel or on banners:

Tipped publisher and confirmed tip went thru: