Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes verified message on tipping banner #6983

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 29, 2020

Resolves brave/brave-browser#12362

Submitter Checklist:

Test Plan:

defined in the issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Oct 29, 2020
@NejcZdovc NejcZdovc requested a review from a team as a code owner October 29, 2020 17:27
@NejcZdovc NejcZdovc self-assigned this Oct 29, 2020
@NejcZdovc NejcZdovc force-pushed the connected-publisher branch from 59a9787 to 42ff670 Compare October 29, 2020 17:27
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 879d358 into master Oct 30, 2020
@NejcZdovc NejcZdovc deleted the connected-publisher branch October 30, 2020 06:58
brave-builds pushed a commit that referenced this pull request Oct 30, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 3, 2020

Verified using

Brave | 1.18.30 Chromium: 87.0.4280.40 (Official Build) nightly (x86_64)
-- | --
Revision | 349b9adbfb2784db684617c7731a57d1e61b3be0-refs/branch-heads/4280@{#863}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified STR from brave/brave-browser#12362 (comment) using staging env.

1. Visit non-verified creator with Uphold wallet connected

Visited non-verified creators (ex. google.com, nytimes.com, buzzfeed.com, etc). Confirmed messaging on panel and in banner:
1a
1b
1c

Tipped publisher and confirmed tip shows in Pending list:
1d

2. Visit verified, not KYC'd creator with Uphold wallet connected

Visited verified, non-KYC'd creators (ex. Duckduckgo.com, youtube.com/user/jjdsampson, reddit.com/user/alex_the_brave, etc). Confirmed messaging on panel and in banner:
2a
2b
2c

Tipped publisher and confirmed tip shows in Pending list:
2d

3. Visit verified, KYC'd creator with Uphold wallet connected

Visited verified, KYC'd creators (ex. github.com/laurenwags, twitter.com/emerick, 3zsistemi.si, etc). Confirmed no messaging on panel or on banner:
3a
3b
3c

Tipped publisher and confirmed tip went thru:
3d1
3d2
3d3

4. Visit non-verified creator with anon wallet connected

Visited non-verified creators (ex. google.com, nytimes.com, buzzfeed.com, etc). Confirmed messaging on panel and in banner:
4a
4b
4c

Tipped publisher and confirmed tip shows in Pending list:
4d

5. Visit verified, not KYC'd creator with anon wallet connected

Visited verified, non-KYC'd creators (ex. Duckduckgo.com, youtube.com/user/jjdsampson, reddit.com/user/alex_the_brave, etc). Confirmed no messaging on panel or on banner:
5a
5b
5c

Tipped publisher and confirmed tip went thru:
5d1
5d2
5d3
5d4
Screen Shot 2020-11-03 at 3 28 02 PM

6. Visit verified, KYC'd creator with anon wallet connected

Visited verified, KYC'd creators (ex. github.com/laurenwags, twitter.com/emerick, 3zsistemi.si, etc). Confirmed no messaging on panel or on banner:
6a
6b
6c

Tipped publisher and confirmed tip went thru:
6d1
6d2
6d3
6d4
6d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] tipping banners do not show messaging for creators not being able to accept tips
3 participants