Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable certificate error assistant #13010

Closed
jumde opened this issue Dec 3, 2020 · 2 comments
Closed

Enable certificate error assistant #13010

jumde opened this issue Dec 3, 2020 · 2 comments
Assignees
@fmarier
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude security
Milestone
1.20.x - Release

Comments

@jumde
Copy link
Contributor

jumde commented Dec 3, 2020

Description

Certificate error assistant is currently not installed in brave. This component presents special interstitial pages for pages like mitm-software or captive-portal.
@jumde jumde mentioned this issue Dec 3, 2020
Closed
5 tasks
@mherrmann
Copy link

Similar to #12999: At the moment, Certificate Error Assistant appears in brave://components as version 0.0.0.0 and stays this way forever. My fix for #8709 will actually remove this zombie appearance. But whoever implements this present issue to bring it back can simply look at my fix and remove Certificate Error Assistant (ID giekcmmlnklenlaomppkphknjmnnpneh) from the list of blacklisted components.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 8, 2020
@fmarier fmarier self-assigned this Dec 23, 2020
fmarier added a commit to fmarier/brave-core that referenced this issue Dec 23, 2020
@fmarier
Enable Certificate Error Assistant component (fixes brave/brave-brows…
4a6a718 
…er#13010)
fmarier added a commit to brave/brave-core that referenced this issue Jan 5, 2021
@fmarier
Enable Certificate Error Assistant component (fixes brave/brave-brows…
f9cd224 
…er#13010)
@fmarier fmarier mentioned this issue Jan 5, 2021
Merged
23 tasks
fmarier added a commit to brave/brave-core that referenced this issue Jan 9, 2021
@fmarier
Enable Certificate Error Assistant component (fixes brave/brave-brows…
a7a9450 
…er#13010)
@fmarier fmarier added this to the 1.20.x - Nightly milestone Jan 13, 2021
@LaurenWags LaurenWags mentioned this issue Jan 22, 2021
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jan 22, 2021 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.20.87 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 10.15.7 (Build 19H15)

Verified as part of #12999 (comment)

cert err ast - installed

Verification passed on


Brave | 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified as part of #12999 (comment)

image
image

Verification passed on

Brave 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Verified as part of #12999

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude security
Projects
None yet
Milestone
1.20.x - Release
Development

No branches or pull requests
7 participants
@fmarier @mherrmann @jumde @rebron @LaurenWags @btlechowski @GeetaSarvadnya