Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay blocked indicator shows up when media is not autoplayed #13167

Closed
darkdh opened this issue Dec 11, 2020 · 3 comments · Fixed by brave/brave-core#7436
Closed

Autoplay blocked indicator shows up when media is not autoplayed #13167

darkdh opened this issue Dec 11, 2020 · 3 comments · Fixed by brave/brave-core#7436

Comments

@darkdh
Copy link
Member

darkdh commented Dec 11, 2020

Description

Autoplay blocked indicator appears when there is a media element

Steps to Reproduce

  1. Use fresh profile and make sure global autoplay setting is allowed and no entries in block list (brave://settings/content/autoplay)
  2. Visit https://www.imdb.com/title/tt1190634/?ref_=nv_sr_srsg_0
  3. There is no video being autoplayed
  4. Change the global autoplay setting to blocked
  5. Visit https://www.imdb.com/title/tt1190634/?ref_=nv_sr_srsg_0
  6. Autoplay blocked indicator is the the top right of url bar even though there is nothing being autoplayed

Actual result:

Autoplay blocked indicator is the the top right of url bar even though there is nothing being autoplayed

Expected result:

There should not be a autoplay blocked indicator when media is not autoplayed

Reproduces how often:

always

Brave version (brave://version info)

1.18.70

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    yes
  • Can you reproduce this issue with the beta channel?
    yes
  • Can you reproduce this issue with the nightly channel?
    yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@btlechowski
Copy link

btlechowski commented Jan 21, 2021

Verification passed on

Brave 1.20.86 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified autoplay is enabled by default in brave://settings/content/autoplay and there is no entries in block list
image
Verified when autoplay is enabled there is no video autoplayed on https://www.imdb.com/title/tt1190634/?ref_=nv_sr_srsg_0
image
Verified when autoplay is disabled there is no video autoplayed on https://www.imdb.com/title/tt1190634/?ref_=nv_sr_srsg_0 and Autoplay blocked indicator is not shown
image


Verification passed on

Brave | 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified test plan from the description
Verified autoplay is enabled by default in brave://settings/content/autoplay and there is no entries in the block list
image
Verified when autoplay is enabled there is no video autoplayed on https://www.imdb.com/title/tt1190634/?ref_=nv_sr_srsg_0

Example Example
image image

Verified when autoplay is disabled there is no video autoplayed on https://www.imdb.com/title/tt1190634/?ref_=nv_sr_srsg_0 and Autoplay blocked indicator is not shown

Example Example
image image

@stephendonner
Copy link

Verified using the testplan, on

Brave 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 11.1 (Build 20C69)

When autoplay is set to blocked, I don't get the autoplay-blocked indicator on https://www.imdb.com/title/tt1190634/?ref_=nv_sr_srsg_0

Screen Shot 2021-01-25 at 2 49 06 PM

Also verified that I could reproduce the problem, pre-fix, using

Brave 1.19.86 Chromium: 88.0.4324.96 (Official Build) (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 11.1 (Build 20C69)

Screen Shot 2021-01-25 at 2 42 01 PM

@LaurenWags / @kjozwiak do we also want to verify on M1?

@kjozwiak
Copy link
Member

kjozwiak commented Jan 25, 2021

For now we're only verifying issues on Intel x64. However, if we start noticing that we're getting regressions/reports that are only happening on Arm x64 and not Intel x64 we'll need to start checking on both. We do check and make sure that the different types of executables are working without issues and that upgrades retain data as per #13577. We added the QA Pass-macOS-arm64 label as we had a few issues that were specific to Arm x64 when we initially started work on the different executables.

Added the QA Pass-macOS label as it looks like it's working as per #13167 (comment). Good job verifying 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment